Skip to content

feat: waitForDomChange, waitForElement, waitForElementToBeRemoved #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2019
Merged

feat: waitForDomChange, waitForElement, waitForElementToBeRemoved #60

merged 2 commits into from
Dec 4, 2019

Conversation

timdeschryver
Copy link
Member

No description provided.

@timdeschryver timdeschryver changed the title feat: add waitForElement and waitForElementToBeRemoved feat: add waitForDomChange, waitForElement, waitForElementToBeRemoved Dec 3, 2019
@timdeschryver
Copy link
Member Author

timdeschryver commented Dec 3, 2019 •
edited
Loading

cc @GregOnNet , I think this would also provide a solution to #38 (instead of using tick and detectChanges manually).

@GregOnNet
Copy link
Contributor

Hi,

this looks awesome.
I also like the naming.
It adds more meaning than tick.
Nice job. 👍

@timdeschryver timdeschryver changed the title feat: add waitForDomChange, waitForElement, waitForElementToBeRemoved feat: waitForDomChange, waitForElement, waitForElementToBeRemoved Dec 4, 2019
@timdeschryver timdeschryver merged commit a3975cd into master Dec 4, 2019
@timdeschryver timdeschryver deleted the wait-for-element branch December 4, 2019 07:45
@timdeschryver
Copy link
Member Author

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timdeschryver @GregOnNet