feat: allow TextMatch to be any non-nullable type #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 30f3880:
|
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 922 922
Branches 281 281
=========================================
Hits 922 922
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 7.27.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
I'll work on the docs next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: TextMatch is allowed to be of any non-nullable type (
anyexceptundefinedandnull)Why: Error messages show confusing failed method calls instead of attempting to treat the TextMatch as a string implicitly (fixes #826)
How: Call
String()whenever the TextMatch matcher isn't aRegExporFunction(allowing it to beanyinstead ofstring)Checklist:
docs site