Merge branch 'master' into fix-banner-attribute-rule

Author: benmonro

.all-contributorsrc

@@ -154,6 +154,17 @@
         "code",
         "test"
       ]
+    },
+    {
+      "login": "G-Rath",
+      "name": "Gareth Jones",
+      "avatar_url": "https://avatars.githubusercontent.com/u/3151613?v=4",
+      "profile": "https://github.com/G-Rath",
+      "contributions": [
+        "test",
+        "code",
+        "bug"
+      ]
     }
   ]
 }

README.md

@@ -14,7 +14,7 @@
 [![MIT License][license-badge]][license]
 
 <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
-[![All Contributors](https://img.shields.io/badge/all_contributors-14-orange.svg?style=flat-square)](#contributors-)
+[![All Contributors](https://img.shields.io/badge/all_contributors-15-orange.svg?style=flat-square)](#contributors-)
 <!-- ALL-CONTRIBUTORS-BADGE:END -->
 [![PRs Welcome][prs-badge]][prs]
 [![Code of Conduct][coc-badge]][coc]
@@ -161,6 +161,9 @@ Thanks goes to these people ([emoji key][emojis]):
     <td align="center"><a href="http://juzerzarif.com"><img src="https://avatars3.githubusercontent.com/u/22772637?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Juzer Zarif</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-jest-dom/commits?author=juzerzarif" title="Code">💻</a> <a href="https://github.com/testing-library/eslint-plugin-jest-dom/commits?author=juzerzarif" title="Tests">⚠️</a> <a href="https://github.com/testing-library/eslint-plugin-jest-dom/issues?q=author%3Ajuzerzarif" title="Bug reports">🐛</a></td>
     <td align="center"><a href="http://everlong.org/"><img src="https://avatars.githubusercontent.com/u/454175?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Julien Wajsberg</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-jest-dom/commits?author=julienw" title="Code">💻</a> <a href="https://github.com/testing-library/eslint-plugin-jest-dom/commits?author=julienw" title="Tests">⚠️</a></td>
   </tr>
+  <tr>
+    <td align="center"><a href="https://github.com/G-Rath"><img src="https://avatars.githubusercontent.com/u/3151613?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Gareth Jones</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-jest-dom/commits?author=G-Rath" title="Tests">⚠️</a> <a href="https://github.com/testing-library/eslint-plugin-jest-dom/commits?author=G-Rath" title="Code">💻</a> <a href="https://github.com/testing-library/eslint-plugin-jest-dom/issues?q=author%3AG-Rath" title="Bug reports">🐛</a></td>
+  </tr>
 </table>
 
 <!-- markdownlint-restore -->

src/__tests__/lib/rules/prefer-in-document.js

@@ -36,6 +36,9 @@ const valid = [
       foo = somethingElse;
       expect(foo).toHaveLength(1);`,
   ]),
+  `expect().not.toBeNull()`,
+  `expect(myFunction()).toBe();`,
+  `expect(myFunction()).toHaveLength();`,
   `let foo;
   foo = "bar";
   expect(foo).toHaveLength(1);`,

src/rules/prefer-in-document.js

@@ -32,8 +32,10 @@ function isAntonymMatcher(matcherNode, matcherArguments) {
 }
 
 function usesToBeOrToEqualWithNull(matcherNode, matcherArguments) {
-  return (matcherNode.name === "toBe" || matcherNode.name === "toEqual") &&
-    matcherArguments[0].value === null;
+  return (
+    (matcherNode.name === "toBe" || matcherNode.name === "toEqual") &&
+    matcherArguments[0].value === null
+  );
 }
 
 function usesToHaveLengthZero(matcherNode, matcherArguments) {
@@ -71,7 +73,7 @@ export const create = (context) => {
     if (!queryNode || (!queryNode.name && !queryNode.property)) return;
 
     // toHaveLength() is only invalid with 0 or 1
-    if (matcherNode.name === "toHaveLength") {
+    if (matcherNode.name === "toHaveLength" && matcherArguments.length) {
       const lengthValue = getLengthValue(matcherArguments);
       // isNotToHaveLengthZero represents .not.toHaveLength(0) which is a valid use of toHaveLength
       const isNotToHaveLengthZero =
@@ -89,7 +91,10 @@ export const create = (context) => {
 
     // toBe() or toEqual() are only invalid with null
     if (matcherNode.name === "toBe" || matcherNode.name === "toEqual") {
-      if (!usesToBeOrToEqualWithNull(matcherNode, matcherArguments)) {
+      if (
+        !matcherArguments.length ||
+        !usesToBeOrToEqualWithNull(matcherNode, matcherArguments)
+      ) {
         return;
       }
     }
@@ -146,6 +151,10 @@ export const create = (context) => {
     [`CallExpression[callee.object.object.callee.name='expect'][callee.object.property.name='not'][callee.property.name=${alternativeMatchers}], CallExpression[callee.object.callee.name='expect'][callee.object.property.name='not'][callee.object.arguments.0.argument.callee.name=${alternativeMatchers}]`](
       node
     ) {
+      if (!node.callee.object.object.arguments.length) {
+        return;
+      }
+
       const arg = node.callee.object.object.arguments[0];
       const queryNode =
         arg.type === "AwaitExpression" ? arg.argument.callee : arg.callee;