Skip to content

feat: new rule prefer-to-have-attribute #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 17, 2019

Conversation

benmonro
Copy link
Member

No description provided.

@benmonro benmonro merged commit 18b4258 into master Nov 17, 2019
@benmonro benmonro deleted the feature/prefer-to-have-attribute branch November 17, 2019 22:33
@benmonro
Copy link
Member Author

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@benmonro
Copy link
Member Author

@nickmccurdy @gnapse i just published a new version w/ this new rule for prefer-to-have-attribute (see readme for details). was hoping either or both of you might be able to give this new rule a spin and give me any feedback you might have. many thx in advance

@nickserv
Copy link
Member

This seems useful, shouldn't it be recommended?

@benmonro
Copy link
Member Author

Yeah but wanted someone else to try it out first before that.

@nickserv
Copy link
Member

Seems to be working 😄I vote we recommend it

// error  Use toHaveAttribute instead of asserting on getAttribute  jest-dom/prefer-to-have-attribute
expect(button.getAttribute("type")).toBe("button");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants