From 0512ce6f4ddf4da1aa7a8dd349027e41472bb84a Mon Sep 17 00:00:00 2001 From: Ben Monro Date: Mon, 4 Nov 2019 08:23:05 -0800 Subject: [PATCH] Revert "Autogenerate recommended config" --- README.md | 6 +++- lib/index.js | 14 ++++----- package.json | 4 +-- tests/__snapshots__/index.test.js.snap | 41 +------------------------- tests/index.test.js | 11 +------ 5 files changed, 14 insertions(+), 62 deletions(-) diff --git a/README.md b/README.md index 6a92439..6484eaa 100644 --- a/README.md +++ b/README.md @@ -34,7 +34,11 @@ Then configure the rules you want to use under the rules section. ```json { - "rules": {} + "rules": { + "jest-dom/prefer-checked": "error", + "jest-dom/prefer-enabled-disabled": "error", + "jest-dom/prefer-required": "error" + } } ``` diff --git a/lib/index.js b/lib/index.js index 836ec75..9a93894 100644 --- a/lib/index.js +++ b/lib/index.js @@ -17,17 +17,13 @@ let requireIndex = require('requireindex'); // import all rules in lib/rules module.exports.rules = requireIndex(__dirname + '/rules'); -module.exports.generateRecommendedConfig = rules => { - return Object.entries(rules).reduce( - (memo, [name, rule]) => - rule.meta.docs.recommended ? { ...memo, [name]: 'error' } : memo, - {} - ); -}; - module.exports.configs = { recommended: { plugins: ['jest-dom'], - rules: module.exports.generateRecommendedConfig(module.exports.rules), + rules: { + 'jest-dom/prefer-checked': 'error', + 'jest-dom/prefer-enabled-disabled': 'error', + 'jest-dom/prefer-required': 'error', + }, }, }; diff --git a/package.json b/package.json index 436373d..ed8c1c4 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,7 @@ "generate-readme-table": "node build/generate-readme-table.js" }, "dependencies": { - "requireindex": "~1.2.0" + "requireindex": "~1.1.0" }, "devDependencies": { "eslint": "^6.6.0", @@ -30,4 +30,4 @@ "node": ">=0.10.0" }, "license": "ISC" -} +} \ No newline at end of file diff --git a/tests/__snapshots__/index.test.js.snap b/tests/__snapshots__/index.test.js.snap index a10e7eb..2165588 100644 --- a/tests/__snapshots__/index.test.js.snap +++ b/tests/__snapshots__/index.test.js.snap @@ -1,42 +1,3 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`should have all the rules 1`] = ` -Object { - "prefer-checked": Object { - "create": [Function], - "meta": Object { - "docs": Object { - "category": "jest-dom", - "description": "prefer toBeChecked over checking attributes", - "recommended": true, - "url": "prefer-checked", - }, - "fixable": "code", - }, - }, - "prefer-enabled-disabled": Object { - "create": [Function], - "meta": Object { - "docs": Object { - "category": "jest-dom", - "description": "prefer toBeDisabled or toBeEnabled over checking attributes", - "recommended": true, - "url": "prefer-enabled-disabled", - }, - "fixable": "code", - }, - }, - "prefer-required": Object { - "create": [Function], - "meta": Object { - "docs": Object { - "category": "jest-dom", - "description": "prefer toBeRequired over checking properties", - "recommended": true, - "url": "prefer-required", - }, - "fixable": "code", - }, - }, -} -`; +exports[`should have all the rules 1`] = `Object {}`; diff --git a/tests/index.test.js b/tests/index.test.js index a24f168..a2fbeff 100644 --- a/tests/index.test.js +++ b/tests/index.test.js @@ -1,14 +1,5 @@ -const { rules, generateRecommendedConfig, configs } = require('../lib/index'); +const { rules } = require('../lib/index'); it('should have all the rules', () => { expect(rules).toMatchSnapshot(); }); - -it('should have a recommended config with recommended rules', () => { - expect( - generateRecommendedConfig({ - good: { meta: { docs: { recommended: true } } }, - bad: { meta: { docs: { recommended: false } } }, - }) - ).toEqual({ good: 'error' }); -});