chore: don't warn on unused variables beginning with _

MichaelDeBoey · MichaelDeBoey · commit acad7e2b5cc9 · 2021-04-28T20:36:35.000+02:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -23,6 +23,7 @@
   },
   "rules": {
     "no-var": "error",
-    "@typescript-eslint/explicit-function-return-type": "off"
+    "@typescript-eslint/explicit-function-return-type": "off",
+    "@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_" }]
   }
 }
diff --git a/tools/generate-configs/index.ts b/tools/generate-configs/index.ts
@@ -13,7 +13,6 @@ const getRecommendedRulesForTestingFramework = (
   framework: SupportedTestingFramework
 ): LinterConfigRules =>
   Object.entries(rules)
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     .filter(([_, { meta: { docs } }]) =>
       Boolean(docs.recommendedConfig[framework])
     )

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@`
`23`	`23`	`},`
`24`	`24`	`"rules": {`
`25`	`25`	`"no-var": "error",`
`26`		`- "@typescript-eslint/explicit-function-return-type": "off"`
	`26`	`+ "@typescript-eslint/explicit-function-return-type": "off",`
	`27`	`+ "@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_" }]`
`27`	`28`	`}`
`28`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,6 @@ const getRecommendedRulesForTestingFramework = (`
`13`	`13`	`framework: SupportedTestingFramework`
`14`	`14`	`): LinterConfigRules =>`
`15`	`15`	`Object.entries(rules)`
`16`		`- // eslint-disable-next-line @typescript-eslint/no-unused-vars`
`17`	`16`	`.filter(([_, { meta: { docs } }]) =>`
`18`	`17`	`Boolean(docs.recommendedConfig[framework])`
`19`	`18`	`)`