From c425954369de5b1369027dbcf89f0c38bc6655a5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20De=20Boey?= Date: Thu, 23 Sep 2021 17:20:17 +0200 Subject: [PATCH] feat(prefer-query-by-disappearance): add to all configs by default BREAKING CHANGE: `prefer-query-by-disappearance` is now enabled by default in all configs --- README.md | 2 +- lib/configs/angular.ts | 1 + lib/configs/dom.ts | 1 + lib/configs/react.ts | 1 + lib/configs/vue.ts | 1 + lib/rules/prefer-query-by-disappearance.ts | 8 ++++---- tests/__snapshots__/index.test.ts.snap | 4 ++++ 7 files changed, 13 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 4fab0e47..f3cd4eaa 100644 --- a/README.md +++ b/README.md @@ -209,7 +209,7 @@ To enable this configuration use the `extends` property in your | [`testing-library/prefer-explicit-assert`](./docs/rules/prefer-explicit-assert.md) | Suggest using explicit assertions rather than standalone queries | | | | [`testing-library/prefer-find-by`](./docs/rules/prefer-find-by.md) | Suggest using `find(All)By*` query instead of `waitFor` + `get(All)By*` to wait for elements | 🔧 | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] | | [`testing-library/prefer-presence-queries`](./docs/rules/prefer-presence-queries.md) | Ensure appropriate `get*`/`query*` queries are used with their respective matchers | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] | -| [`testing-library/prefer-query-by-disappearance`](./docs/rules/prefer-query-by-disappearance.md) | Suggest using `queryBy*` queries when waiting for disappearance | | | +| [`testing-library/prefer-query-by-disappearance`](./docs/rules/prefer-query-by-disappearance.md) | Suggest using `queryBy*` queries when waiting for disappearance | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] | | [`testing-library/prefer-screen-queries`](./docs/rules/prefer-screen-queries.md) | Suggest using `screen` while querying | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] | | [`testing-library/prefer-user-event`](./docs/rules/prefer-user-event.md) | Suggest using `userEvent` over `fireEvent` for simulating user interactions | | | | [`testing-library/prefer-wait-for`](./docs/rules/prefer-wait-for.md) | Use `waitFor` instead of deprecated wait methods | 🔧 | | diff --git a/lib/configs/angular.ts b/lib/configs/angular.ts index 066e5d45..af9b277c 100644 --- a/lib/configs/angular.ts +++ b/lib/configs/angular.ts @@ -20,6 +20,7 @@ export = { 'testing-library/no-wait-for-snapshot': 'error', 'testing-library/prefer-find-by': 'error', 'testing-library/prefer-presence-queries': 'error', + 'testing-library/prefer-query-by-disappearance': 'error', 'testing-library/prefer-screen-queries': 'error', 'testing-library/render-result-naming-convention': 'error', }, diff --git a/lib/configs/dom.ts b/lib/configs/dom.ts index 935fd36e..ce153733 100644 --- a/lib/configs/dom.ts +++ b/lib/configs/dom.ts @@ -15,6 +15,7 @@ export = { 'testing-library/no-wait-for-snapshot': 'error', 'testing-library/prefer-find-by': 'error', 'testing-library/prefer-presence-queries': 'error', + 'testing-library/prefer-query-by-disappearance': 'error', 'testing-library/prefer-screen-queries': 'error', }, }; diff --git a/lib/configs/react.ts b/lib/configs/react.ts index 9f509ce3..81fb1a8c 100644 --- a/lib/configs/react.ts +++ b/lib/configs/react.ts @@ -21,6 +21,7 @@ export = { 'testing-library/no-wait-for-snapshot': 'error', 'testing-library/prefer-find-by': 'error', 'testing-library/prefer-presence-queries': 'error', + 'testing-library/prefer-query-by-disappearance': 'error', 'testing-library/prefer-screen-queries': 'error', 'testing-library/render-result-naming-convention': 'error', }, diff --git a/lib/configs/vue.ts b/lib/configs/vue.ts index 5b637a80..cf9e42bb 100644 --- a/lib/configs/vue.ts +++ b/lib/configs/vue.ts @@ -21,6 +21,7 @@ export = { 'testing-library/no-wait-for-snapshot': 'error', 'testing-library/prefer-find-by': 'error', 'testing-library/prefer-presence-queries': 'error', + 'testing-library/prefer-query-by-disappearance': 'error', 'testing-library/prefer-screen-queries': 'error', 'testing-library/render-result-naming-convention': 'error', }, diff --git a/lib/rules/prefer-query-by-disappearance.ts b/lib/rules/prefer-query-by-disappearance.ts index e65f9db7..cc2d6671 100644 --- a/lib/rules/prefer-query-by-disappearance.ts +++ b/lib/rules/prefer-query-by-disappearance.ts @@ -25,10 +25,10 @@ export default createTestingLibraryRule({ 'Suggest using `queryBy*` queries when waiting for disappearance', category: 'Possible Errors', recommendedConfig: { - dom: false, - angular: false, - react: false, - vue: false, + dom: 'error', + angular: 'error', + react: 'error', + vue: 'error', }, }, messages: { diff --git a/tests/__snapshots__/index.test.ts.snap b/tests/__snapshots__/index.test.ts.snap index 0d9a6eb9..e67072cd 100644 --- a/tests/__snapshots__/index.test.ts.snap +++ b/tests/__snapshots__/index.test.ts.snap @@ -25,6 +25,7 @@ Object { "testing-library/no-wait-for-snapshot": "error", "testing-library/prefer-find-by": "error", "testing-library/prefer-presence-queries": "error", + "testing-library/prefer-query-by-disappearance": "error", "testing-library/prefer-screen-queries": "error", "testing-library/render-result-naming-convention": "error", }, @@ -44,6 +45,7 @@ Object { "testing-library/no-wait-for-snapshot": "error", "testing-library/prefer-find-by": "error", "testing-library/prefer-presence-queries": "error", + "testing-library/prefer-query-by-disappearance": "error", "testing-library/prefer-screen-queries": "error", }, }, @@ -76,6 +78,7 @@ Object { "testing-library/no-wait-for-snapshot": "error", "testing-library/prefer-find-by": "error", "testing-library/prefer-presence-queries": "error", + "testing-library/prefer-query-by-disappearance": "error", "testing-library/prefer-screen-queries": "error", "testing-library/render-result-naming-convention": "error", }, @@ -104,6 +107,7 @@ Object { "testing-library/no-wait-for-snapshot": "error", "testing-library/prefer-find-by": "error", "testing-library/prefer-presence-queries": "error", + "testing-library/prefer-query-by-disappearance": "error", "testing-library/prefer-screen-queries": "error", "testing-library/render-result-naming-convention": "error", },