Skip to content
This repository was archived by the owner on Jul 30, 2020. It is now read-only.

fix: removed old ByA11yStates and ByA11yTraits typings, added ByDispl… #40

Merged
merged 1 commit into from
Jun 29, 2019

Conversation

mateusz1913
Copy link
Contributor

…ayValue and ByTitle typings

What:

#39
As in the issue, removing old typings and add typings for new queries

Why:

To use ByDisplayValue and ByTitle in projects with Typescript

How:

Changed exported types from typings/queries.d.ts

Checklist:

  • Documentation added to the
    docs site(N/A)
  • Typescript definitions updated
  • Tests(N/A)
  • Ready to be merged

@codecov-io
Copy link

codecov-io commented Jun 29, 2019

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #40   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines         262    262           
  Branches       65     65           
=====================================
  Hits          262    262

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f52ab5d...97103ed. Read the comment docs.

Copy link
Collaborator

@bcarroll22 bcarroll22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! @allcontributors please add @mateusz1913 for code

@bcarroll22
Copy link
Collaborator

Hmm weird. @allcontributors please add @mateusz1913 for code

@allcontributors
Copy link
Contributor

@bcarroll22

I've put up a pull request to add @mateusz1913! 🎉

@bcarroll22 bcarroll22 merged commit 4233b05 into testing-library:master Jun 29, 2019
@bcarroll22
Copy link
Collaborator

🎉 This PR is included in version 4.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants