fix: Update types to support all possible react component return values#1272
Merged
eps1lon merged 2 commits intotesting-library:mainfrom Feb 1, 2024
Merged
fix: Update types to support all possible react component return values#1272eps1lon merged 2 commits intotesting-library:mainfrom
eps1lon merged 2 commits intotesting-library:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0c2672e:
|
Member
|
@all-contributors add @trappar for code |
Contributor
|
I've put up a pull request to add @trappar! 🎉 |
|
@eps1lon Changing |
|
We see failures with this message now:
|
|
Missing breaking change? Broke our tests. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Fixes: #1271
Why: To improve typescript types
How: N/A
Checklist:
docs site N/A