Skip to content

latest svelte@5 broke its tests #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yanick opened this issue Apr 18, 2024 · 6 comments
Closed

latest svelte@5 broke its tests #353

yanick opened this issue Apr 18, 2024 · 6 comments

Comments

@yanick
Copy link
Collaborator

yanick commented Apr 18, 2024

see #352

@yanick
Copy link
Collaborator Author

yanick commented Apr 18, 2024

Reported to the mothership, in case it could help: sveltejs/svelte#11228

@mcous
Copy link
Collaborator

mcous commented Apr 18, 2024

Weirdly enough, I cannot reproduce this failure locally on the same Svelte version

❯ npm why svelte
[email protected] dev

I wonder if there's a race condition here? Maybe tick() isn't fully flushing updates, and that's what CI is hitting

@mcous
Copy link
Collaborator

mcous commented Apr 19, 2024

More testing results:

Will add this to the thread over in svelte, too

@mcous
Copy link
Collaborator

mcous commented Apr 19, 2024

Oh hm mothership issue has been closed with a fix that "preserves accessors with HMR." That's odd, because we have HMR disabled in our test suite. Will wait on the next.109 release though and see what happens

@mcous
Copy link
Collaborator

mcous commented Apr 20, 2024

@yanick looks like this has, in fact, been fixed upstream. Your report did the trick. I can no longer repro locally nor in CI

@yanick
Copy link
Collaborator Author

yanick commented Apr 20, 2024

W00t! That was easy. ^.^

@yanick yanick closed this as completed Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants