Conversation
smeijer
force-pushed
the
feature/eventlog
branch
from
e113d34 to
50a28d0
Compare
This was referenced Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Based on/inspired by testing-library/user-event#351
Why:
Because we can (support this).
How:
I've added a
/eventsroute, and aDomEventscomponent. This component reuses thePreviewcomponent, and just listens to all events that happen there.Events are stored on a reference, and NOT in state, as a performance optimization. Once every 16 ms the
eventCountis synced back to the state, to trigger a component update when necessary.There are still some things to do, but I'll create an issue for that. I think it's already useful in the current form and by breaking up we keep the changes small.
Checklist: