fix: move target node for event logger a few nodes down#190
Merged
Conversation
smeijer
force-pushed
the
feature/fix-height
branch
from
17eedaa to
bc2cb8b
Compare
Member
Author
|
@marcosvega91 & @sumeesh879, can you check if this fixes the problem that was mentioned in #178 (comment)? |
|
@smeijer I still see the issue in this PR preview.
I think you'll still need to compare innerRef height with outerRef height. @marcosvega91's last commit 97840de on #178 seems to have fixed it. |
Member
Author
|
Yeah, that commit looked like it. But it isn't really. As your screenshot also shows, for some reason items 0, 1 and 2 aren't rendered. There is a bit more going on than just those ref heights. *edit |
smeijer
changed the title
smeijer
force-pushed
the
feature/fix-height
branch
from
73dbb67 to
0ba33e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
I've changed the node to which
DomEventslistens for events. The node was positioned insideDomEvents, now we're listening to thePreviewroot instead.Why:
Listening to a node that wraps the entire preview pane, causes unrelated events to be logged. This is because the
Previewcomponent doesn't only hold the raw markup, it also containsScrollableandAutoSizer(resize detectors).The
AutoSizertriggers on page load, so it caused the first events to be directly added on-page load. This change fixes that as well.How:
Use the callback ref to bind the events directly on the correct root node, instead of wrapping the entire
<Preview>component.Checklist: