fix: fix css flex/height issues in safari#248
Merged
smeijer merged 2 commits intotesting-library:developfrom Jul 6, 2020
Merged
fix: fix css flex/height issues in safari#248smeijer merged 2 commits intotesting-library:developfrom
smeijer merged 2 commits intotesting-library:developfrom
Conversation
smeijer
reviewed
Jul 6, 2020
Member
smeijer
left a comment
smeijer
left a comment
There was a problem hiding this comment.
Thanks 👍 Looking good!
Two small requests so we can make it more future proof. Mostly so that we won't be confused when working on this in the future.
Can you apply those changes?
Contributor
Author
|
Thanks @smeijer! I've applied the fixes you requested. Thanks for tidying that up. |
smeijer
changed the title
Member
|
@all-contributors please add @bmeverett for code |
Contributor
|
I've put up a pull request to add @bmeverett! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fix #238
Why:
To improve how the site looks and behaves in Safari to make it align with Chrome.
How:
Update css classes to work on Safari. I'm not the best at css, but I removed/added some classes to make Safari show more like Chrome. I checked Chrome while making these changes as well and it didn't seem to be affected. Happy to look at a different/better way of doing things, or if there was something I missed
Safari
Chrome
Checklist: