feat: add warning message returned from @testing-library/dom#270
Merged
smeijer merged 3 commits intotesting-library:developfrom Oct 9, 2020
Merged
Conversation
marcosvega91
force-pushed
the
pr/add_warning_message
branch
from
d2f147f to
82af9d6
Compare
Member
|
Thanks! This is awesome. I'm just wondering, based on the screenshot, should we still show that "this is awesome..." message? Or should the warning be shown instead of it? |
Member
Author
|
I was thinking about this too. The query is the best one that you can use but the message will only warning you for that use case. So I think that we can leave as is for now. |
Member
|
Thanks again. Sorry I've waited so long with the merge 😔 |
Member
Author
|
no problem 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: I have update @testing-library/dom and @testing-library/user-event to the latest versions and add a new warning message to the
ResultSuggestioncomponent (look here)Why: Because on @testing-library/dom we return from
getSuggestedQuerya new fieldwarningused to give some advice to the user.Now this field is only used to show to the user the following message
Element is inaccessible. This means that the element and all its children are invisible to screen readers. If you are using the aria-hidden prop, make sure this is the right choice for your case.when the selected element is hidden
How: I have added a new div like the image below
Checklist: