fix: make default oembed panes equal to embed modal#292
Merged
smeijer merged 5 commits intotesting-library:developfrom Oct 31, 2020
Merged
fix: make default oembed panes equal to embed modal#292smeijer merged 5 commits intotesting-library:developfrom
smeijer merged 5 commits intotesting-library:developfrom
Conversation
MichaelDeBoey
force-pushed
the
update-embed-panes
branch
from
d20320b to
588437e
Compare
MichaelDeBoey
force-pushed
the
update-embed-panes
branch
from
588437e to
8f16c8c
Compare
smeijer
changed the title
MichaelDeBoey
force-pushed
the
update-embed-panes
branch
3 times, most recently
from
398c174 to
a81ecd9
Compare
MichaelDeBoey
force-pushed
the
update-embed-panes
branch
from
96ea596 to
741f48e
Compare
smeijer
force-pushed
the
update-embed-panes
branch
from
741f48e to
e427d61
Compare
smeijer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we should make the default panes of the embed consistent with the default panes from the embed modal