Add v3 definitions for Ergodox EZ Shine/Glow variants #2367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These keyboards use separate product IDs which currently makes them unrecognizable from VIA's perspective. This change adds two new JSONs that only differ in product ID to account for the missing variants.
Collaborator
|
Marked as invalid. The PR checklist and PR procedures are not followed. @drozdziak1 |
Lemon2ee
added a commit
to Lemon2ee/via-keyboards
that referenced
this pull request
May 15, 2025
…nitions for Ergodox EZ Shine/Glow variants Automatically merging PR the-via#2367 from https://github.com/the-via/keyboards/ Original PR: the-via#2367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These keyboards use separate product IDs which currently makes
them unrecognizable from VIA's perspective. This change adds two new
JSONs that only differ in product ID and keyboard name to account for the missing variants.