Skip to content

Conversation

@mattchan
Copy link
Contributor

@mattchan mattchan commented May 31, 2025

Description

Fixes #2452.

The hineybush h101 PCB has matrix positions for the full numpad Enter and the full numpad + keys mapped to an incorrect row. This causes the keypresses when using full numpad Enter and full numpad + to not fire. This can be observed using the Via Key Tester. The correction for this is to map the full numpad Enter and full numpad + to one row up in the matrix.

Note: This was tested using the hotswap version of the h101 PCB since I do not have a solder version on hand to test with.

Before Fix

Below is the KLE for the incorrect matrix. As you can see, full numpad + and full numpad Enter are mapped to 3,21 and 5,21 respectively.
h101_kle_incorrect_matrix

This results in the following matrix display in Via.
h101_incorrect_matrix

As a result, this does not result in any observed key presses in the Key Tester.
h101_incorrect_matrix_key_tester

After Fix

The corrected KLE layout with full numpad + and full numpad Enter mapped to 2,21 and 4,21.
h101_kle_corrected_matrix

The corrected matrix appearance in Via.
h101_corrected_matrix

The corrected matrix registering as key events in Key Tester.
h101_corrected_matrix_key_tester

QMK Pull Request

The hineybush/h101 in QMK was originally added in qmk/qmk_firmware#22186.

VIA Keymap Pull Request

The VIA keymap for the h101 PCB was originally added in PR #2048.

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hineybush/h101 - Incorrect matrix positions for full numpad + and full numpad Enter

1 participant