hineybush/h101 - Fix full numpad + and full numpad Enter matrix positions #2453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2452.
The hineybush h101 PCB has matrix positions for the full numpad Enter and the full numpad + keys mapped to an incorrect row. This causes the keypresses when using full numpad Enter and full numpad + to not fire. This can be observed using the Via Key Tester. The correction for this is to map the full numpad Enter and full numpad + to one row up in the matrix.
Note: This was tested using the hotswap version of the h101 PCB since I do not have a solder version on hand to test with.
Before Fix
Below is the KLE for the incorrect matrix. As you can see, full numpad + and full numpad Enter are mapped to

3,21and5,21respectively.This results in the following matrix display in Via.

As a result, this does not result in any observed key presses in the Key Tester.

After Fix
The corrected KLE layout with full numpad + and full numpad Enter mapped to

2,21and4,21.The corrected matrix appearance in Via.

The corrected matrix registering as key events in Key Tester.

QMK Pull Request
The hineybush/h101 in QMK was originally added in qmk/qmk_firmware#22186.
VIA Keymap Pull Request
The VIA keymap for the h101 PCB was originally added in PR #2048.
Checklist
0xFEED