Add Snappy Pad v.1

[snappykey]

Description

Add Snappy Pad v.1 to Keyboards repo

QMK Pull Request

qmk/qmk_firmware#25419

VIA Keymap Pull Request

the-via/qmk_userspace_via#97

Checklist

• The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
• VIA keymap is MERGED in VIA userspace master already (MANDATORY)
• The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
• I have a V3 JSON version for this keyboard definition.(MANDATORY)
• I have formatted the JSON file to have consistent formatting with the rest of the repository.
• I have tested this keyboard definition using VIA's "Design" tab.
• I have tested this keyboard definition with firmware on a device.
• I have assigned alpha keys and modifier keys with the correct colors.
• The Vendor ID is not 0xFEED

[Cipulot]

@snappykey you can remove the file in the src folder, which is not needed.
Furthermore, the submitted json doesn't actually match the keyboard you merged; it's missing the top left key, as well as the push button within the encoder.
It needs work for the time being until this is addressed.

[snappykey]

@snappykey you can remove the file in the src folder, which is not needed. Furthermore, the submitted json doesn't actually match the keyboard you merged; it's missing the top left key, as well as the push button within the encoder. It needs work for the time being until this is addressed.

Hello Cipulot. Currently top left key and encoders button is NOT configurable. I will delete src folder.

[Cipulot]

@snappykey you can remove the file in the src folder, which is not needed. Furthermore, the submitted json doesn't actually match the keyboard you merged; it's missing the top left key, as well as the push button within the encoder. It needs work for the time being until this is addressed.

Hello Cipulot. Currently top left key and encoders button is NOT configurable. I will delete src folder.

mmmmm given that it's exposed in the keymap it should be remappable by default.

[snappykey]

Yes. but in VIA app it shouldnt be configurable. They are not connected in matrix either. QMK maintainers changed it so, that it would be easier to read.

[snappykey]

I will maybe update it in the future, but for now its good like this.

[Cipulot]

That's not how the configurator should be approached.
The board pictured in the QMK merge is this one:

This clearly shows that the top left is a key that is available, as well as an encoder on the right that has push capabilities.

They are not connected in matrix either

This is...... not correct either, if a key is pushable and does things, it's part of the matrix that is scanned. If it was no part of the matrix then it wouldn't be added to the keymap.

Again, being user accessible they should be exposed.

[snappykey]

Encoder and top left key are connected to two other pins, they are not in the matrix. Do you want to see the pcb?

[Cipulot]

For a key to be in the matrix it doesn't need to be in the square/ractangle matrix.

[snappykey]

Okay, so what should I do now?

[Cipulot]

Okay, so what should I do now?

You should expose the keys in the json to make them customizable as the other keys based on their matrix location of the QMK firmware.

[snappykey]

I think this should be merged. I could do this later. Is that okay?

[Cipulot]

No?

The PRs are merged once completed, incomplete works and implementations are discouraged.

[snappykey]

@Cipulot now this top left button is good, but how do I add button to encoder?
["0,4",{"x":2,"a":7},"e0"],
[{"y":0.5,"a":4},
"0,0","0,1","0,2","0,3"],
["1,0","1,1","1,2","1,3"],
["2,0","2,1","2,2","2,3"]

[snappykey]

oh nvm, I found it online

[snappykey]

Now this is the new code, I will go commit it
{
"name": "Snappy Pad v1",
"vendorId": "0x16D0",
"productId": "0x1451",
"matrix": {
"rows": 3,
"cols": 6
},
"layouts": {
"keymap": [

        ["0,4",{"x":2},"0,5\n\n\n\n\n\n\n\n\ne0"],
        [{"y":0.5},"0,0","0,1","0,2","0,3"],
        ["1,0","1,1","1,2","1,3"],
        ["2,0","2,1","2,2","2,3"]



    ]
}

}

[snappykey]

@Cipulot everything is setup, can you merge it?

[Cipulot]

Pull changes and modify the path as follows: v3/snappypad/snappy_pad_v1.json

This is ti comply with the rest of the repo usual formatting.