Use addr2line for backtraces (oxidecomputer#557)

* Use addr2line for stack traces

* Better file printing

* Add comment about dwarf ownership

* Skip addr2line if any frames are invalid

* Run test suite

Author: mkeeter

Cargo.lock

@@ -190,6 +190,7 @@ cmd-vpd = { path = "./cmd/vpd", package = "humility-cmd-vpd" }
 cmd-writeword = { path = "./cmd/writeword", package = "humility-cmd-writeword" }
 
 # crates.io deps
+addr2line = "0.25"
 anyhow = { version = "1.0.44", features = ["backtrace"] }
 atty = "0.2"
 bitfield = "0.13.2"

Cargo.toml

@@ -17,7 +17,7 @@
 
 [package]
 name = "humility-bin"
-version = "0.12.7"
+version = "0.12.8"
 edition = "2021"
 license = "MPL-2.0"
 

humility-bin/Cargo.toml

@@ -13,7 +13,7 @@ For more information try --help
 
 ```
 $ humility --chip this-can-be-anything -V
-humility 0.12.7 
+humility 0.12.8 
 
 ```
 
@@ -28,7 +28,7 @@ For more information try --help
 
 ```
 $ humility -c apx432 -V
-humility 0.12.7 
+humility 0.12.8 
 
 ```
 

humility-bin/tests/cmd/chip.trycmd

@@ -14,7 +14,7 @@
    SP = 0x24000288 <- kernel: 0x24000000+0x288
         |
         +--->  0x240002c0 0x080019ac kern::fail::die_impl
-               0x240002d0 0x080019d0 kern::fail::die
+               0x240002d0 0x080019d4 kern::fail::die
                0x240002d0 0x080019d4 rust_begin_unwind
                0x240002f0 0x080006da core::panicking::panic_fmt
                0x24000318 0x0800105a core::panicking::panic

humility-bin/tests/cmd/registers-s/registers-s.kernel-panic.1.stdout

@@ -14,11 +14,11 @@
    SP = 0x20002b70 <- i2c_driver: 0x20002800+0x370
         |
         +--->  0x20002b80 0x08015ac8 userlib::sys_irq_control_stub
-               0x20002c00 0x080148e2 drv_stm32h7_i2c::I2cController::write_read
-               0x20002c00 0x08014658 drv_stm32h7_i2c_server::main::{{closure}}
-               0x20002c00 0x08014658 userlib::hl::recv_without_notification::{{closure}}
-               0x20002c00 0x080142d4 userlib::hl::recv
-               0x20002c00 0x080142d4 userlib::hl::recv_without_notification
+               0x20002c00 0x08014920 drv_stm32h7_i2c::I2cController::write_read
+               0x20002c00 0x08014920 drv_stm32h7_i2c_server::main::{{closure}}
+               0x20002c00 0x08014920 userlib::hl::recv_without_notification::{{closure}}
+               0x20002c00 0x08014920 userlib::hl::recv
+               0x20002c00 0x08014920 userlib::hl::recv_without_notification
                0x20002c00 0x08014920 main
                0x20002c00 0x0801404e _start
 

humility-bin/tests/cmd/registers-s/registers-s.kiowa.4.stdout

@@ -14,16 +14,16 @@
    SP = 0x20002ae0 <- i2c_driver: 0x20002800+0x2e0
         |
         +--->  0x20002af0 0x08016408 userlib::sys_irq_control_stub
-               0x20002b20 0x08015b9c drv_stm32h7_i2c::I2cController::write_read
-               0x20002b20 0x08015b9c drv_stm32h7_i2c::ltc4306::write_reg_u8
+               0x20002b20 0x08015bc0 drv_stm32h7_i2c::I2cController::write_read
+               0x20002b20 0x08015bc0 drv_stm32h7_i2c::ltc4306::write_reg_u8
                0x20002b20 0x08015bc0 <drv_stm32h7_i2c::ltc4306::Ltc4306 as drv_stm32h7_i2c::I2cMuxDriver>::enable_segment
-               0x20002c00 0x08014852 drv_stm32h7_i2c_server::configure_mux::{{closure}}
-               0x20002c00 0x08014830 drv_stm32h7_i2c_server::find_mux
-               0x20002c00 0x08014830 drv_stm32h7_i2c_server::configure_mux
-               0x20002c00 0x0801476e drv_stm32h7_i2c_server::main::{{closure}}
-               0x20002c00 0x0801476e userlib::hl::recv_without_notification::{{closure}}
-               0x20002c00 0x0801447a userlib::hl::recv
-               0x20002c00 0x0801447a userlib::hl::recv_without_notification
+               0x20002c00 0x080148a8 drv_stm32h7_i2c_server::configure_mux::{{closure}}
+               0x20002c00 0x080148a8 drv_stm32h7_i2c_server::find_mux
+               0x20002c00 0x080148a8 drv_stm32h7_i2c_server::configure_mux
+               0x20002c00 0x080148a8 drv_stm32h7_i2c_server::main::{{closure}}
+               0x20002c00 0x080148a8 userlib::hl::recv_without_notification::{{closure}}
+               0x20002c00 0x080148a8 userlib::hl::recv
+               0x20002c00 0x080148a8 userlib::hl::recv_without_notification
                0x20002c00 0x080148a8 main
                0x20002c00 0x0801404e _start
 

humility-bin/tests/cmd/registers-s/registers-s.kiowa.49.stdout

@@ -13,8 +13,8 @@
   R12 = 0x20002a48 <- i2c_driver: 0x20002800+0x248
    SP = 0x20000eb0 <- kernel: 0x20000000+0xeb0
         |
-        +--->  0x20000f58 0x08002090 kern::syscalls::syscall_entry::{{closure}}
-               0x20000f58 0x08002074 kern::arch::arm_m::with_task_table
+        +--->  0x20000f58 0x08002094 kern::syscalls::syscall_entry::{{closure}}
+               0x20000f58 0x08002094 kern::arch::arm_m::with_task_table
                0x20000f58 0x08002094 syscall_entry
                0x20000f58 0x0800375a SVCall
 

humility-bin/tests/cmd/registers-s/registers-s.kiowa.50.stdout

@@ -15,10 +15,10 @@
         |
         +--->  0x20000f58 0x080022ee <kern::arch::arm_m::SavedState as kern::task::ArchState>::arg1
                0x20000f58 0x080022ee kern::task::AsIrqArgs<&T>::control
-               0x20000f58 0x080022dc kern::syscalls::irq_control
-               0x20000f58 0x080020a0 kern::syscalls::safe_syscall_entry
-               0x20000f58 0x080020a0 kern::syscalls::syscall_entry::{{closure}}
-               0x20000f58 0x08002074 kern::arch::arm_m::with_task_table
+               0x20000f58 0x080022ee kern::syscalls::irq_control
+               0x20000f58 0x080022ee kern::syscalls::safe_syscall_entry
+               0x20000f58 0x080022ee kern::syscalls::syscall_entry::{{closure}}
+               0x20000f58 0x080022ee kern::arch::arm_m::with_task_table
                0x20000f58 0x080022ee syscall_entry
                0x20000f58 0x0800375a SVCall
 

humility-bin/tests/cmd/registers-s/registers-s.kiowa.51.stdout

@@ -14,12 +14,12 @@
    SP = 0x20000e80 <- kernel: 0x20000000+0xe80
         |
         +--->  0x20000e80 0x0800153c kern::umem::USlice<T>::last_byte_addr
-               0x20000eb0 0x080033b2 kern::umem::USlice<T>::aliases
+               0x20000eb0 0x080033bc kern::umem::USlice<T>::aliases
                0x20000eb0 0x080033bc kern::umem::safe_copy
-               0x20000f58 0x080021c0 kern::syscalls::borrow_read
-               0x20000f58 0x080020a0 kern::syscalls::safe_syscall_entry
-               0x20000f58 0x080020a0 kern::syscalls::syscall_entry::{{closure}}
-               0x20000f58 0x08002074 kern::arch::arm_m::with_task_table
+               0x20000f58 0x08002244 kern::syscalls::borrow_read
+               0x20000f58 0x08002244 kern::syscalls::safe_syscall_entry
+               0x20000f58 0x08002244 kern::syscalls::syscall_entry::{{closure}}
+               0x20000f58 0x08002244 kern::arch::arm_m::with_task_table
                0x20000f58 0x08002244 syscall_entry
                0x20000f58 0x0800375a SVCall