Skip to content

Commit a8914fc

Browse files
committed
Lint files and add .gitignore
1 parent 415ddad commit a8914fc

File tree

9 files changed

+159
-142
lines changed

9 files changed

+159
-142
lines changed

.gitignore

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
lib-cov
2+
*.seed
3+
*.log
4+
*.csv
5+
*.dat
6+
*.out
7+
*.pid
8+
*.gz
9+
10+
pids
11+
logs
12+
results
13+
coverage
14+
15+
npm-debug.log
16+
node_modules
17+
.DS_Store

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ node_js:
33
- '4'
44
- '6'
55
before_install:
6-
- 'npm install npm@latest codeclimate-test-reporter -g'
6+
- 'npm install npm@latest -g && npm install codeclimate-test-reporter -g'
77
addons:
88
code_climate:
9-
repo_token: token
9+
repo_token: ab787af5893136974fbed7aed384ac31d06f2a886a56110648bf3f8dfcec42ab
1010
after_script:
1111
- 'npm run gen-coverage && cat coverage/lcov.info | codeclimate-test-reporter'

index.js

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,45 @@
11
'use strict'
22

3-
const Hoek = require('hoek');
3+
const Assert = require('assert')
44

55
class JSONErrors {
6-
constructor() {
7-
this.errors = new Array();
6+
constructor () {
7+
this.errors = []
88
}
99

10-
get() {
11-
return { errors: this.errors };
10+
get () {
11+
return { errors: this.errors }
1212
}
1313

14-
create(id, message, meta) {
15-
var error = {};
14+
create (id, message, meta) {
15+
var error = {}
1616

17-
Hoek.assert(id !== undefined, 'id required');
18-
Hoek.assert(message !== undefined, 'message required');
17+
Assert(id, 'id required')
18+
Assert(message, 'message required')
1919

20-
error.id = id;
21-
error.message = message;
20+
error.id = id
21+
error.message = message
2222

23-
if (meta) error.meta = meta;
23+
if (meta) error.meta = meta
2424

25-
return error;
25+
return error
2626
}
2727

28-
createSingle(id, message, meta) {
29-
var errors = new JSONErrors();
28+
createSingle (id, message, meta) {
29+
var errors = new JSONErrors()
3030

31-
errors.add(id, message, meta);
32-
return errors.get();
31+
errors.add(id, message, meta)
32+
return errors.get()
3333
}
3434

35-
add(id, message, meta) {
36-
var error = this.create(id, message, meta);
37-
this.errors.push(error);
35+
add (id, message, meta) {
36+
var error = this.create(id, message, meta)
37+
this.errors.push(error)
3838
}
3939

40-
clear() {
41-
this.errors = new Array();
40+
clear () {
41+
this.errors = []
4242
}
43-
};
43+
}
4444

45-
module.exports = JSONErrors;
45+
module.exports = JSONErrors

package.json

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
{
22
"name": "json-api-errors",
3-
"version": "0.1.0",
3+
"version": "0.0.1",
44
"description": "JSON api errors formatter",
55
"main": "errors.js",
66
"scripts": {
7+
"gen-coverage": "lab --coverage --reporter lcov --output coverage/lcov.info",
8+
"lint": "standard",
9+
"pretest": "npm run lint",
710
"test": "lab -c"
811
},
912
"keywords": [
@@ -25,9 +28,7 @@
2528
"license": "MIT",
2629
"devDependencies": {
2730
"code": "3.0.2",
28-
"lab": "11.0.1"
29-
},
30-
"dependencies": {
31-
"hoek": "^4.0.2"
31+
"lab": "11.0.1",
32+
"standard": "8.0.0"
3233
}
3334
}

test/clear.js

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,32 @@
1-
const Code = require('code');
2-
const Lab = require('lab');
1+
const Code = require('code')
2+
const Lab = require('lab')
33

4-
const JSONErrors = require('..');
4+
const JSONErrors = require('..')
55

6-
const lab = exports.lab = Lab.script();
6+
const lab = exports.lab = Lab.script()
77

8-
const describe = lab.describe;
9-
const it = lab.it;
10-
const expect = Code.expect;
11-
const beforeEach = lab.beforeEach;
8+
const describe = lab.describe
9+
const it = lab.it
10+
const expect = Code.expect
11+
const beforeEach = lab.beforeEach
1212

13-
var Client, err, errObject;
13+
var Client, err
1414

1515
describe('JSONErrors.clear', () => {
16-
err = { id: 'CUSTOM_ERROR', message: 'This is a custom error message' };
16+
err = { id: 'CUSTOM_ERROR', message: 'This is a custom error message' }
1717

1818
beforeEach((done) => {
19-
Client = new JSONErrors();
20-
Client.add(err.id, err.message);
21-
done();
22-
});
19+
Client = new JSONErrors()
20+
Client.add(err.id, err.message)
21+
done()
22+
})
2323

2424
it('clears out errors', (done) => {
25-
var errors;
26-
27-
Client.clear();
28-
errors = Client.get();
29-
expect(errors.errors).to.have.length(0);
30-
done();
31-
});
32-
});
25+
var errors
26+
27+
Client.clear()
28+
errors = Client.get()
29+
expect(errors.errors).to.have.length(0)
30+
done()
31+
})
32+
})

test/create.js

Lines changed: 31 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,54 @@
1-
const Code = require('code');
2-
const Lab = require('lab');
1+
const Code = require('code')
2+
const Lab = require('lab')
33

4-
const JSONErrors = require('..');
4+
const JSONErrors = require('..')
55

6-
const lab = exports.lab = Lab.script();
6+
const lab = exports.lab = Lab.script()
77

8-
const describe = lab.describe;
9-
const it = lab.it;
10-
const expect = Code.expect;
11-
const beforeEach = lab.beforeEach;
8+
const describe = lab.describe
9+
const it = lab.it
10+
const expect = Code.expect
11+
const beforeEach = lab.beforeEach
1212

13-
var Client, err, errObject;
13+
var Client, err
1414

1515
describe('JSONErrors.create', () => {
16-
err = { id: 'CUSTOM_ERROR', message: 'This is a custom error' };
17-
errObject = { errors: [{ id: err.id, message: err.message }] };
16+
err = { id: 'CUSTOM_ERROR', message: 'This is a custom error' }
1817

1918
beforeEach((done) => {
20-
Client = new JSONErrors();
21-
done();
22-
});
19+
Client = new JSONErrors()
20+
done()
21+
})
2322

2423
describe('validation', () => {
2524
it('fails if no id is provided', (done) => {
2625
expect(() => {
27-
ClientClient.create(null, err.message);
28-
}).to.throw();
26+
Client.create(null, err.message)
27+
}).to.throw()
2928

30-
done();
31-
});
29+
done()
30+
})
3231

3332
it('fails if no message is provided', (done) => {
3433
expect(() => {
35-
ClientClient.create(err.id, null);
36-
}).to.throw();
34+
Client.create(err.id, null)
35+
}).to.throw()
3736

38-
done();
39-
});
40-
});
37+
done()
38+
})
39+
})
4140

4241
it('creates an error object', (done) => {
43-
var error = Client.create(err.id, err.message);
42+
var error = Client.create(err.id, err.message)
4443

45-
expect(error).to.equal(err);
46-
done();
47-
});
44+
expect(error).to.equal(err)
45+
done()
46+
})
4847

4948
it('adds meta to the error when specified', (done) => {
50-
var error = Client.create(err.id, err.message, 'meta');
49+
var error = Client.create(err.id, err.message, 'meta')
5150

52-
expect(error.meta).to.equal('meta');
53-
done();
54-
});
55-
});
51+
expect(error.meta).to.equal('meta')
52+
done()
53+
})
54+
})

test/createSingle.js

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
1-
const Code = require('code');
2-
const Lab = require('lab');
1+
const Code = require('code')
2+
const Lab = require('lab')
33

4-
const JSONErrors = require('..');
4+
const JSONErrors = require('..')
55

6-
const lab = exports.lab = Lab.script();
6+
const lab = exports.lab = Lab.script()
77

8-
const describe = lab.describe;
9-
const it = lab.it;
10-
const expect = Code.expect;
8+
const describe = lab.describe
9+
const it = lab.it
10+
const expect = Code.expect
1111

12-
var Client, err, errObject;
12+
var Client, err, errObject
1313

1414
describe('JSONErrors.createSingle', () => {
15-
err = { id: 'CUSTOM_ERROR', message: 'This is a custom error'};
16-
errObject = { errors: [{ id: err.id, message: err.message }] };
17-
Client = new JSONErrors();
15+
err = { id: 'CUSTOM_ERROR', message: 'This is a custom error' }
16+
errObject = { errors: [{ id: err.id, message: err.message }] }
17+
Client = new JSONErrors()
1818

1919
it('creates a single errors object', (done) => {
20-
var errors = Client.createSingle(err.id, err.message);
20+
var errors = Client.createSingle(err.id, err.message)
2121

22-
expect(errors).to.equal(errObject);
23-
done();
24-
});
25-
});
22+
expect(errors).to.equal(errObject)
23+
done()
24+
})
25+
})

test/get.js

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,38 @@
1-
const Code = require('code');
2-
const Lab = require('lab');
1+
const Code = require('code')
2+
const Lab = require('lab')
33

4-
const JSONErrors = require('..');
4+
const JSONErrors = require('..')
55

6-
const lab = exports.lab = Lab.script();
6+
const lab = exports.lab = Lab.script()
77

8-
const describe = lab.describe;
9-
const it = lab.it;
10-
const expect = Code.expect;
11-
const beforeEach = lab.beforeEach;
12-
const afterEach = lab.afterEach;
8+
const describe = lab.describe
9+
const it = lab.it
10+
const expect = Code.expect
11+
const beforeEach = lab.beforeEach
12+
const afterEach = lab.afterEach
1313

14-
var Client, err, errObject;
14+
var Client, err, errObject
1515

1616
describe('JSONErrors.get', () => {
17-
err = { id: 'CUSTOM_ERROR', message: 'This is a custom error message' };
18-
errObject = { errors: [{ id: err.id, message: err.message }] };
17+
err = { id: 'CUSTOM_ERROR', message: 'This is a custom error message' }
18+
errObject = { errors: [{ id: err.id, message: err.message }] }
1919

2020
beforeEach((done) => {
21-
Client = new JSONErrors();
22-
Client.add(err.id, err.message);
23-
done();
24-
});
21+
Client = new JSONErrors()
22+
Client.add(err.id, err.message)
23+
done()
24+
})
2525

2626
afterEach((done) => {
27-
Client.clear();
28-
done();
29-
});
27+
Client.clear()
28+
done()
29+
})
3030

3131
it('returns errors as object', (done) => {
32-
var errors = Client.get();
32+
var errors = Client.get()
3333

34-
expect(errors).to.be.an.object();
35-
expect(errors).to.equal(errObject);
36-
done();
37-
});
38-
});
34+
expect(errors).to.be.an.object()
35+
expect(errors).to.equal(errObject)
36+
done()
37+
})
38+
})

0 commit comments

Comments
 (0)