bridge_info: implement missing rtnl_link_info_ops::io_compare() #427
+48
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm not 100% confident about the |
KanjiMonster
force-pushed
the
jogo_fix_bridge_info_compare
branch
2 times, most recently
from
55d39f1 to
615a8c8
Compare
Contributor
Author
|
Updated to follow the way how https://github.com/thom311/libnl/blob/main/lib/route/addr.c#L565-L569 handles the |
thom311
reviewed
Jun 10, 2025
KanjiMonster
force-pushed
the
jogo_fix_bridge_info_compare
branch
from
615a8c8 to
dba3764
Compare
Without rtnl_link_info_ops::io_compare() changes in link info are not picked up by the cache and no notificatons are sent out as rtnl_link_info_data_compare() returns 0 when the callback is missing. Fix this by implementing the missing io_compare() for bridge_info. This allows e.g. changes in ageing time to be seen. Fixes: 7391a38 ("bridge: Add support for link_info of a bridge") Signed-off-by: Jonas Gorski <[email protected]>
KanjiMonster
force-pushed
the
jogo_fix_bridge_info_compare
branch
from
dba3764 to
b343aaa
Compare
thom311
pushed a commit
that referenced
this pull request
Aug 13, 2025
Without rtnl_link_info_ops::io_compare() changes in link info are not picked up by the cache and no notificatons are sent out as rtnl_link_info_data_compare() returns 0 when the callback is missing. Fix this by implementing the missing io_compare() for bridge_info. This allows e.g. changes in ageing time to be seen. Fixes: 7391a38 ("bridge: Add support for link_info of a bridge") Signed-off-by: Jonas Gorski <[email protected]> #427
Owner
|
merged as 320b2bd thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without rtnl_link_info_ops::io_compare() changes in link info are not picked up by the cache and no notificatons are sent out as rtnl_link_info_data_compare() returns 0 when the callback is missing.
Fix this by implementing the missing io_compare() for bridge_info.
This allows e.g. changes in ageing time to be seen.
Fixes: 7391a38 ("bridge: Add support for link_info of a bridge")