Remove breaks that coincide with the limits of the scale (#4423)

thomasp85 · web-flow · commit 0e142bb312d1 · 2021-04-19T09:43:19.000+02:00
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,8 @@
 # ggplot2 (development version)
 
+* Fix bug in `guide_coloursteps()` that would repeat the terminal bins if the
+  breaks coincided with the limits of the scale (@thomasp85, #4019)
+  
 * Extent the range of the line created by `geom_abline()` so that line ending
   is not visible for large linewidths (@thomasp85, #4024)
 
diff --git a/R/guide-colorsteps.R b/R/guide-colorsteps.R
@@ -64,6 +64,7 @@ guide_train.colorsteps <- function(guide, scale, aesthetic = NULL) {
     }
     if (is.numeric(breaks)) {
       limits <- scale$get_limits()
+      breaks <- breaks[!breaks %in% limits]
       all_breaks <- c(limits[1], breaks, limits[2])
       bin_at <- all_breaks[-1] - diff(all_breaks) / 2
     } else {

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,7 @@ guide_train.colorsteps <- function(guide, scale, aesthetic = NULL) {`
`64`	`64`	`}`
`65`	`65`	`if (is.numeric(breaks)) {`
`66`	`66`	`limits <- scale$get_limits()`
	`67`	`+ breaks <- breaks[!breaks %in% limits]`
`67`	`68`	`all_breaks <- c(limits[1], breaks, limits[2])`
`68`	`69`	`bin_at <- all_breaks[-1] - diff(all_breaks) / 2`
`69`	`70`	`} else {`