Warn when a supplied mapping is going to be overwritten by geom_hline / vline / abline (#2950)

* Added warning to geom_hline-vline-abline when a supplied mapping is going to be overwritten.

* moved in warnings into act like annotation ifs

* removed plot from tests

* removed stray 'plot'

* removed extraneous if conditions and suggested solution fromwarning

* removed 'both'

* fixed spacing

* updated expected error message

* updated expected error message

* updated expected error message

* roxygen documentation update

* added description of changes to NEWS.md

* more concise news entry

* added missing space in test

Author: RichardJActon

NEWS.md

@@ -1,4 +1,6 @@
 # ggplot2 3.1.0.9000
+
+* `geom_hline()`, `geom_vline()`, and `geom_abline()` now throw a warning if the user supplies both an `xintercept`, `yintercept`, or `slope` value and a mapping (@RichardJActon, #2950).
 
 * `scale_color_continuous()` now points at `scale_colour_continuos()` so that it 
   will handle `type = "viridis"` as the documentation states (@hlendway, #3079).

R/geom-abline.r

@@ -82,6 +82,16 @@ geom_abline <- function(mapping = NULL, data = NULL,
 
   # Act like an annotation
   if (!missing(slope) || !missing(intercept)) {
+
+    # Warn if supplied mapping is going to be overwritten
+    if (!missing(mapping)) {
+      warning(paste0("Using `intercept` and/or `slope` with `mapping` may",
+                     " not have the desired result as mapping is overwritten",
+                     " if either of these is specified\n"
+              )
+      )
+    }
+
     if (missing(slope)) slope <- 1
     if (missing(intercept)) intercept <- 0
     n_slopes <- max(length(slope), length(intercept))

R/geom-hline.r

@@ -11,6 +11,14 @@ geom_hline <- function(mapping = NULL, data = NULL,
 
   # Act like an annotation
   if (!missing(yintercept)) {
+    # Warn if supplied mapping is going to be overwritten
+    if (!missing(mapping)) {
+      warning(paste0("Using both `yintercept` and `mapping` may not have the",
+                     " desired result as mapping is overwritten if",
+                     " `yintercept` is specified\n"
+              )
+      )
+    }
     data <- new_data_frame(list(yintercept = yintercept))
     mapping <- aes(yintercept = yintercept)
     show.legend <- FALSE

R/geom-vline.r

@@ -11,6 +11,14 @@ geom_vline <- function(mapping = NULL, data = NULL,
 
   # Act like an annotation
   if (!missing(xintercept)) {
+    # Warn if supplied mapping is going to be overwritten
+    if (!missing(mapping)) {
+      warning(paste0("Using both `xintercept` and `mapping` may not have the",
+                     " desired result as mapping is overwritten if",
+                     " `xintercept` is specified\n"
+              )
+      )
+    }
     data <- new_data_frame(list(xintercept = xintercept))
     mapping <- aes(xintercept = xintercept)
     show.legend <- FALSE

man/borders.Rd

@@ -43,3 +43,33 @@ test_that("curved lines in map projections", {
     nzmap + coord_map(projection = 'azequalarea', orientation = c(-36.92, 174.6, 0))
   )
 })
+
+# Warning tests ------------------------------------------------------------
+
+test_that("Warning if a supplied mapping is going to be overwritten", {
+
+  expect_warning(
+    geom_vline(xintercept = 3, aes(colour = colour)),
+    "Using both"
+  )
+
+  expect_warning(
+    geom_hline(yintercept = 3, aes(colour = colour)),
+    "Using both"
+  )
+
+  expect_warning(
+    geom_abline(intercept = 3, aes(colour = colour)),
+    "Using "
+  )
+
+  expect_warning(
+    geom_abline(intercept = 3, slope = 0.5, aes(colour = colour)),
+    "Using "
+  )
+
+  expect_warning(
+    geom_abline(slope=0.5, aes(colour = colour)),
+    "Using "
+  )
+})