Remove filename from the call to custom devices if file is present in the formals (#4674)

thomasp85 · web-flow · commit 391a1647df01 · 2021-11-24T09:25:48.000+01:00
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,8 @@
 # ggplot2 (development version)
 
+* Better compatibility of custom device functions in `ggsave()` 
+  (@thomasp85, #4539)
+
 * Binning scales are now more resilient to calculated limits that ends up being
   `NaN` after transformations (@thomasp85, #4510)
 
diff --git a/R/save.r b/R/save.r
@@ -162,6 +162,7 @@ plot_dev <- function(device, filename = NULL, dpi = 300) {
     call_args <- list()
     if ("file" %in% names(args)) {
       call_args$file <- filename
+      call_args["filename"] <- list(NULL)
     }
     if ("res" %in% names(args)) {
       call_args$res <- dpi

Original file line number	Diff line number	Diff line change
`@@ -162,6 +162,7 @@ plot_dev <- function(device, filename = NULL, dpi = 300) {`
`162`	`162`	`call_args <- list()`
`163`	`163`	`if ("file" %in% names(args)) {`
`164`	`164`	`call_args$file <- filename`
	`165`	`+ call_args["filename"] <- list(NULL)`
`165`	`166`	`}`
`166`	`167`	`if ("res" %in% names(args)) {`
`167`	`168`	`call_args$res <- dpi`