CoordSf needs to define its own is_free() function. Closes #2651. (#2652)

clauswilke · hadley · commit 69dfc4bc6282 · 2018-05-24T08:32:10.000-07:00
diff --git a/R/coord-.r b/R/coord-.r
@@ -87,6 +87,8 @@ Coord <- ggproto("Coord",
 
   is_linear = function() FALSE,
 
+  # Does the coordinate system support free scaling of axes in a faceted plot?
+  # Will generally have to return FALSE for coordinate systems that enforce a fixed aspect ratio.
   is_free = function() FALSE,
 
   setup_params = function(data) {
diff --git a/R/sf.R b/R/sf.R
@@ -353,6 +353,9 @@ CoordSf <- ggproto("CoordSf", CoordCartesian,
     )
   },
 
+  # CoordSf enforces a fixed aspect ratio -> axes cannot be changed freely under faceting
+  is_free = function() FALSE,
+
   aspect = function(self, panel_params) {
     if (isTRUE(sf::st_is_longlat(panel_params$crs))) {
       # Contributed by @edzer

Original file line number	Diff line number	Diff line change
`@@ -353,6 +353,9 @@ CoordSf <- ggproto("CoordSf", CoordCartesian,`
`353`	`353`	`)`
`354`	`354`	`},`
`355`	`355`
	`356`	`+ # CoordSf enforces a fixed aspect ratio -> axes cannot be changed freely under faceting`
	`357`	`+ is_free = function() FALSE,`
	`358`	`+`
`356`	`359`	`aspect = function(self, panel_params) {`
`357`	`360`	`if (isTRUE(sf::st_is_longlat(panel_params$crs))) {`
`358`	`361`	`# Contributed by @edzer`