Better descent (#2996)

Author: thomasp85

R/margins.R

@@ -336,15 +336,15 @@ font_descent <- function(family = "", face = "plain", size = 12, cex = 1) {
   descent <- descent_cache[[key]]
 
   if (is.null(descent)) {
-    descent <- descentDetails(textGrob(
+    descent <- convertHeight(grobDescent(textGrob(
       label = "gjpqyQ",
       gp = gpar(
         fontsize = size,
         cex = cex,
         fontfamily = family,
         fontface = face
       )
-    ))
+    )), 'inches')
     descent_cache[[key]] <- descent
   }
   descent