-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add Dewey Dunnington to core developers #3588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sounds good to me. |
Thanks @yutannihilation for the nomination! I believe I was given push access over the summer because it was somehow tied to the ability to add labels to issues...I only reviewed a few simple tidy-dev-day PRs. If it's the consensus of the rest of you (with no worries either way) I would be honoured to be listed as a core developer. Either way I look forward to being a more active contributor when I'm trying to finish my Ph.D.! |
Thanks for the detail, I got it! It's reasonable that the project lead needs to give a temporary permission to non-core developers in such cases. Probably, it should be written on Anyway, I would be happy to propose adding you to the core team. @hadley, could you handle the confirmation process? I think we can either continue discussing here casually or move to emails.
|
Sorry for dropping the ball on this. I think we can treat this issue as confirmation from the other active core developers. @paleolimbot can you please make a PR that adds yourself to the governance file and closes this issue. |
🎉 |
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
@hadley
I emailed you about this a while ago because
GOVERNANCE.md
says I should do so, but it seems you are too busy to reply. So, I'm opening this issue. Sorry if it's not the right place to discuss here...@paleolimbot made a considerable amount of contributions. I guess we, existing ggplot2 core developers, all agree he deserves the ggplot2 core developer. Actually, it seems he already has the same permissions (to approve and merge PRs) as a core developer. I'm not sure if he is already approved as a core developer, but, in any case, I believe his name should be officially added to authors in DESCRIPTION and GOVERNMENT.md.
The text was updated successfully, but these errors were encountered: