Skip to content

Upkeep for ggplot2 #5220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
36 of 37 tasks
thomasp85 opened this issue Mar 7, 2023 · 5 comments
Closed
36 of 37 tasks

Upkeep for ggplot2 #5220

thomasp85 opened this issue Mar 7, 2023 · 5 comments

Comments

@thomasp85
Copy link
Member

thomasp85 commented Mar 7, 2023

Pre-history

  • usethis::use_readme_rmd()
  • usethis::use_roxygen_md()
  • usethis::use_github_links()
  • usethis::use_pkgdown_github_pages()
  • usethis::use_tidy_github_labels()
  • usethis::use_tidy_style()
  • usethis::use_tidy_description()
  • urlchecker::url_check()

2020

  • usethis::use_package_doc()
    Consider letting usethis manage your @importFrom directives here.
    usethis::use_import_from() is handy for this.
  • usethis::use_testthat(3) and upgrade to 3e, testthat 3e vignette
  • Align the names of R/ files and test/ files for workflow happiness.
    The docs for usethis::use_r() include a helpful script.
    usethis::rename_files() may be be useful.

2021

  • usethis::use_tidy_dependencies()
  • usethis::use_tidy_github_actions() and update artisanal actions to use setup-r-dependencies
  • Remove check environments section from cran-comments.md
  • Bump required R version in DESCRIPTION to 3.5
  • Use lifecycle instead of artisanal deprecation messages, as described in Communicate lifecycle changes in your functions
  • Make sure RStudio appears in Authors@R of DESCRIPTION like so, if appropriate:
    person("RStudio", role = c("cph", "fnd"))

2022

2023

Posit updates:

  • Update copyright holder in DESCRIPTION: person(given = "Posit, PBC", role = c("cph", "fnd"))
  • Double check license file uses '[package] authors' as copyright holder. Run use_mit_license()
  • usethis::use_tidy_coc()
  • Review 2022 checklist to see if you completed the pkgdown updates
  • Modernize citation files; see updated use_citation()
  • Update logo (https://github.com/rstudio/hex-stickers); run use_tidy_logo()
  • Prefer pak::pak("org/pkg") over devtools::install_github("org/pkg") in README
  • Consider running use_tidy_dependencies() and/or replace compat files with use_standalone()
  • use_standalone("r-lib/rlang", "types-check") instead of home grown argument checkers
  • Change files ending in .r to .R in R/ and/or tests/testthat/
  • Add alt-text to pictures, plots, etc; see https://posit.co/blog/knitr-fig-alt/ for examples
  • usethis::use_tidy_github_actions()
@thomasp85
Copy link
Member Author

thomasp85 commented Mar 7, 2023

@teunbrand would you be interested in looking into the rlang typecheck bullet (4th from the bottom) and see if this is something we should do?

@teunbrand
Copy link
Collaborator

Do you mean #5209?

@thomasp85
Copy link
Member Author

ah yes - but using the facilities provided in the standalone file

@teunbrand
Copy link
Collaborator

I'll look into it 👍

@thomasp85
Copy link
Member Author

Also, @teunbrand can you make an issue for alt text in images and tackle it as it fits into your work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants