Skip to content

Simplify check_device() #5470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
teunbrand opened this issue Oct 11, 2023 · 0 comments · Fixed by #5476
Closed

Simplify check_device() #5470

teunbrand opened this issue Oct 11, 2023 · 0 comments · Fixed by #5476
Labels
internals 🔎

Comments

@teunbrand
Copy link
Collaborator

Both {ragg} and {svglite} now support dev.capabilities():

Which means we wouldn't need to special-case these devices in check_device().
We should simplify the manual checks for these devices and instead just suggest to upgrade the packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internals 🔎
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify check_device() for {ragg}/{svglite} teunbrand/ggplot2
1 participant
@teunbrand