Update CI for Go 1.25 (#106)

Author: tiendc

.github/workflows/go.yml

@@ -13,14 +13,14 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        go: ["1.18.x", "1.22.x", "1.23.x"]
+        go: ["1.18.x", "1.23.x", "1.25.x"]
         include:
-          - go: 1.23.x
+          - go: 1.25.x
             latest: true
 
     steps:
       - name: Setup Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: ${{ matrix.go }}
 

.golangci.yml

@@ -1,72 +1,87 @@
-linters-settings:
-  funlen:
-    lines: 160
-    statements: 72
-  gci:
-    sections:
-      - standard
-      - default
-      - prefix(github.com/tiendc/gofn)
-  gocyclo:
-    min-complexity: 30
-  goimports:
-    local-prefixes: github.com/golangci/golangci-lint
-  lll:
-    line-length: 120
-  misspell:
-    locale: US
-
+version: "2"
 linters:
   enable:
     - bodyclose
     - contextcheck
+    - copyloopvar
     - dogsled
-    - errcheck
+    - err113
     - errname
     - errorlint
     - exhaustive
-    - copyloopvar
     - forbidigo
     - forcetypeassert
     - funlen
-    - gci
     - gocognit
     - goconst
     - gocritic
     - gocyclo
-    - err113
-    - gofmt
-    - goimports
-    - mnd
     - gosec
-    - gosimple
-    - govet
-    - ineffassign
     - lll
     - misspell
+    - mnd
     - nakedret
     - nestif
     - nilerr
     - rowserrcheck
     - staticcheck
-    - stylecheck
-    - typecheck
     - unconvert
     - unparam
-    - unused
     - whitespace
     - wrapcheck
-
-issues:
-  exclude-rules:
-    - path: _test\.go
-      linters:
-        - funlen
-        - contextcheck
-        - staticcheck
-        - gocyclo
-        - gocognit
-        - err113
-        - forcetypeassert
-        - wrapcheck
-        - mnd
+  settings:
+    funlen:
+      lines: 120
+      statements: 80
+    gocognit:
+      min-complexity: 20
+    gocyclo:
+      min-complexity: 20
+    lll:
+      line-length: 120
+    misspell:
+      locale: US
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - contextcheck
+          - err113
+          - forcetypeassert
+          - funlen
+          - gocognit
+          - gocyclo
+          - gosec
+          - mnd
+          - staticcheck
+          - wrapcheck
+        path: _test\.go
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gci
+    - gofmt
+    - goimports
+  settings:
+    gci:
+      sections:
+        - standard
+        - default
+        - prefix(github.com/tiendc/gofn)
+    goimports:
+      local-prefixes:
+        - github.com/golangci/golangci-lint
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

Makefile

@@ -1,7 +1,7 @@
 all: lint test
 
 prepare:
-	@curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin v1.60.3
+	@curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin v2.6.0
 
 build:
 	@go build -v ./...

slice_algo.go

@@ -63,10 +63,7 @@ func Chunk[T any, S ~[]T](s S, chunkSize int) []S {
 	}
 
 	chunks := make([]S, 0, len(s)/chunkSize+1)
-	for {
-		if len(s) == 0 {
-			break
-		}
+	for len(s) > 0 {
 		if len(s) < chunkSize {
 			chunkSize = len(s)
 		}

util.go

@@ -4,6 +4,7 @@ import "reflect"
 
 // If returns the 2nd arg if the condition is true, 3rd arg otherwise.
 // This is similar to C-language ternary operation (cond ? val1 : val2).
+//
 // Deprecated: this function may cause unexpected behavior upon misuses.
 //
 //	For example: gofn.If(len(slice) > 0, slice[0], defaultVal) will crash if slice is empty