fix: add object notification filtering #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovaistariq
reviewed
Dec 9, 2024
| 4. `>=` and `<=`: Greater than or equal and less than or equal | ||
| 5. `AND`: Combine multiple conditions in a query. | ||
|
|
||
| ## In Memory Operations |
Contributor
There was a problem hiding this comment.
Do we have to differentiate between SQL and In Memory operations? That might confuse the user. From their perspective it is all the same
Contributor
Author
There was a problem hiding this comment.
My aim was to make sure a user knew they needed to combine these with another filter.
docs/buckets/object-notifications.md
Outdated
|
|
||
| ## Filtering | ||
|
|
||
| Object notifications support adding a SQL-like filter to only receive |
Contributor
There was a problem hiding this comment.
Could you rephrase the content here? There is some duplication.
Contributor
Author
There was a problem hiding this comment.
I've updated it. This should be clearer
garrensmith
force-pushed
the
filtering-notifications
branch
from
67a6969 to
e10d4ba
Compare
ovaistariq
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/tigrisdata/issue/TIG-2941/docs-for-filtering-on-object-notifications