Skip to content

Conversation

@adilansari
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-redirect Ready Ready Preview Comment Oct 27, 2025 11:40pm
tigris-os-docs Ready Ready Preview Comment Oct 27, 2025 11:40pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR adds custom domain management functionality to the Partner Integration API, introducing three new endpoints under /v1/providers/{provider_id}/orgs/{org_id}/buckets/{bucket_name}/domain:

  • POST: Set or replace a custom domain for a bucket
  • GET: Retrieve the current custom domain configuration
  • DELETE: Remove the custom domain from a bucket

The PR also updates the server URL from https://mgmt.storage.dev to https://fly.mgnt.storage.tigris.dev. However, there's a critical spelling error - the URL consistently uses mgnt instead of mgmt (missing the 'e'), which appears in 4 locations throughout the file.

Key changes:

  • Added BucketWebsiteSettings schema with domain_name field
  • Added request/response schemas for custom domain operations
  • Updated BucketInfo schema to include optional website field
  • Updated all documentation examples to use the new server URL

Confidence Score: 2/5

  • This PR has a critical spelling error in the server URL that will cause API requests to fail
  • The spelling error mgnt instead of mgmt appears in 4 locations and will prevent the API from functioning correctly. While the custom domain endpoint implementation looks structurally sound, the misspelled URL is a critical issue that must be fixed before merge
  • The static/api/extensions/v1/api.yaml file needs attention - specifically lines 46, 50, 69, and 1170 where the URL spelling must be corrected

Important Files Changed

File Analysis

Filename Score Overview
static/api/extensions/v1/api.yaml 3/5 Added custom domain endpoints (POST/GET/DELETE) and updated server URL, but URL contains spelling error (mgnt instead of mgmt)

Additional Comments (1)

  1. static/api/extensions/v1/api.yaml, line 1170 (link)

    syntax: mgnt appears to be misspelled - should this be mgmt?

No files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

@adilansari
Copy link
Contributor Author

@adilansari adilansari merged commit f8aea1e into main Oct 28, 2025
10 checks passed
@adilansari adilansari deleted the parter-custom-domain branch October 28, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants