-
Notifications
You must be signed in to change notification settings - Fork 5
Custom domain integration for partner integration APIs #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This PR adds custom domain management functionality to the Partner Integration API, introducing three new endpoints under /v1/providers/{provider_id}/orgs/{org_id}/buckets/{bucket_name}/domain:
- POST: Set or replace a custom domain for a bucket
- GET: Retrieve the current custom domain configuration
- DELETE: Remove the custom domain from a bucket
The PR also updates the server URL from https://mgmt.storage.dev to https://fly.mgnt.storage.tigris.dev. However, there's a critical spelling error - the URL consistently uses mgnt instead of mgmt (missing the 'e'), which appears in 4 locations throughout the file.
Key changes:
- Added
BucketWebsiteSettingsschema withdomain_namefield - Added request/response schemas for custom domain operations
- Updated
BucketInfoschema to include optionalwebsitefield - Updated all documentation examples to use the new server URL
Confidence Score: 2/5
- This PR has a critical spelling error in the server URL that will cause API requests to fail
- The spelling error
mgntinstead ofmgmtappears in 4 locations and will prevent the API from functioning correctly. While the custom domain endpoint implementation looks structurally sound, the misspelled URL is a critical issue that must be fixed before merge - The
static/api/extensions/v1/api.yamlfile needs attention - specifically lines 46, 50, 69, and 1170 where the URL spelling must be corrected
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| static/api/extensions/v1/api.yaml | 3/5 | Added custom domain endpoints (POST/GET/DELETE) and updated server URL, but URL contains spelling error (mgnt instead of mgmt) |
Additional Comments (1)
-
static/api/extensions/v1/api.yaml, line 1170 (link)syntax:
mgntappears to be misspelled - should this bemgmt?
No files reviewed, 4 comments
No description provided.