Skip to content

Conversation

@adilansari
Copy link
Contributor

@adilansari adilansari commented Nov 16, 2025


Summary by Gitar

  • Adds comprehensive object event notification configuration to the Partner API, enabling webhook callbacks when objects are created, updated, or deleted in buckets
  • Introduces two new OpenAPI schemas: ObjectNotifications (with fields for webhook URL, SQL filtering, region, and authentication) and ObjectNotificationAuth (supporting both Basic Auth and Bearer Token)
  • Integrates notification configuration into three bucket management endpoints: BucketOptions (creation), UpdateBucketRequest (updates), and BucketInfo (retrieval responses)
  • Includes detailed documentation with partial update semantics, JSON usage examples, and security notes about credential masking in API responses

@gitar-bot
Copy link

gitar-bot bot commented Nov 16, 2025

Gitar analyzes/fixes CI failures, runs prompts as workflows and addresses comments starting with Gitar (docs)

Rules Evaluated

Gitar Rules

✖️ PR Summary Enhancement: PR description already comprehensive. New commit only refines documentation wording - falls under exclusion for trivial changes. No update needed.

✖️ Flaky Test Auto-Retry: Deterministic Prettier formatting failure, not a flaky test. Will fail consistently until formatting is fixed. No retry appropriate.


⚙️ Options:

  • Auto-apply Gitar suggestions
    Allow Gitar to commit updates to this branch. When off, suggestions appear as comments.

@vercel
Copy link

vercel bot commented Nov 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-redirect Ready Ready Preview Comment Nov 16, 2025 10:22pm
tigris-os-docs Ready Ready Preview Comment Nov 16, 2025 10:22pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 16, 2025

Greptile Summary

  • Adds object notification webhook configuration to Partner API for bucket creation, updates, and retrieval
  • Includes authentication options (basic auth, bearer token) and filtering capabilities for notification events
  • Documentation describes partial update behavior but schema validation contradicts this by marking enabled as required

Confidence Score: 2/5

  • This PR has schema validation issues that will cause runtime conflicts between documented behavior and actual API validation
  • The schema contains logical inconsistencies where documentation promises partial updates by omitting fields, but enabled is marked as required. Additionally, webhook is documented as required when enabled is true but isn't enforced in the schema. These mismatches will cause API validation failures or unexpected behavior.
  • static/api/extensions/v1/api.yaml requires corrections to align schema requirements with documented behavior

Important Files Changed

Filename Overview
static/api/extensions/v1/api.yaml Adds object notification webhook configuration with conflicting requirements between schema validation and documentation for required fields

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 2 comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@gitar-bot
Copy link

gitar-bot bot commented Nov 16, 2025

CI failed for 065f282: CI failed again with the same Prettier formatting issue in the YAML file after the 'improved docs' commit. This is the second occurrence of this formatting error on the PR.

Issue

Prettier formatting check failed (again) for static/api/extensions/v1/api.yaml

Root Cause

The most recent commit 065f282 ("improved docs") modified documentation in the YAML file but introduced formatting inconsistencies. The lint pipeline results:

  1. npm run lint:apidocs - PASSED (API spec is valid)
  2. npm run lint:code - PASSED (ESLint checks passed)
  3. npm run lint:format - FAILED (Prettier formatting issues)

Pattern Observed

This is the second occurrence of this formatting issue on this PR:

  • First occurrence: Initial commit 88bf666 → Fixed with commit 46da3e4 ("lint")
  • Second occurrence: Commit 065f282 ("improved docs") → Currently failing

The author appears to be manually editing the YAML file without running the formatter before committing.

Details

The "improved docs" commit refined documentation wording and examples (28 lines changed) but didn't run Prettier. Common formatting issues in YAML:

  • Inconsistent indentation
  • Trailing spaces
  • Line length violations
  • Quote style inconsistencies

Suggested Fix

Run Prettier with the --write flag:

npx prettier --write static/api/extensions/v1/api.yaml

Or:

npm run format

Recommendation

Consider adding a pre-commit hook or reminder to run npm run lint before pushing to prevent this recurring issue.

Note: This is a tooling/process issue, not a code quality problem. The API specification and documentation content are valid and correct.

Reply with Gitar please fix to apply these suggestions.
Auto-apply is off - enable it here to let Gitar commit future updates automatically.
Did we get this right? 👍 / 👎 to help improve future analysis.

@adilansari adilansari merged commit f7f900d into main Nov 16, 2025
10 checks passed
@adilansari adilansari deleted the obj-notifs branch November 16, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants