-
Notifications
You must be signed in to change notification settings - Fork 5
Remove limited access key IAM use case example #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Gitar analyzes/fixes CI failures, runs prompts as workflows and addresses comments starting with RulesGitar Rules➖ Flaky Test Auto-Retry: CI failure is Prettier formatting error, not flaky test ➖ PR Summary Enhancement: PR description has adequate technical depth; no value to add ⚙️ Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
263dfdf to
9abcc9f
Compare
Greptile OverviewGreptile SummaryRemoved the limited-access-key IAM policy example documentation because string IAM conditions are not yet available in Tigris.
Confidence Score: 0/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (4)
-
docs/model-storage/vast-ai.mdx, line 136-138 (link)logic: Broken link to deleted
limited-access-key.md. Remove or update this reference. -
docs/model-storage/skypilot.mdx, line 147-149 (link)logic: Broken link to deleted
limited-access-key.md. Remove or update this reference. -
docs/model-storage/fly-io.mdx, line 136-138 (link)logic: Broken link to deleted
limited-access-key.md. Remove or update this reference. -
docs/model-storage/beam-cloud.mdx, line 152-154 (link)logic: Broken link to deleted
limited-access-key.md. Remove or update this reference.
2 files reviewed, 5 comments
CI failed for 9abcc9f: The CI build failed because the documentation file was deleted but the corresponding entry in sidebars.js was not removed in the same commit.IssueDocusaurus build is failing with an invalid sidebar configuration error: Root CauseThe commit that CI ran on (
However, it did not update DetailsWhen checking the current HEAD commit (
The current local version shows sidebars.js correctly excludes the deleted document from lines 120-124. Suggested FixThe solution is to ensure the "iam/policies/examples/limited-access-key", // ← This line needs to be removedFrom the items array in the "Example Policies" category section, leaving only:
Reply with |
9abcc9f to
d674f3a
Compare
d674f3a to
6ca5d48
Compare
6ca5d48 to
3440189
Compare
3440189 to
8f6322d
Compare
8f6322d to
f00c1c7
Compare
String IAM conditions are not available yet. Removing example which utilizes such functionality to avoid confusion.