Skip to content

Conversation

@MantasMiksys
Copy link
Contributor

String IAM conditions are not available yet. Removing example which utilizes such functionality to avoid confusion.

@gitar-bot
Copy link

gitar-bot bot commented Nov 24, 2025

Gitar analyzes/fixes CI failures, runs prompts as workflows and addresses comments starting with Gitar (docs)

Rules

Gitar Rules

Flaky Test Auto-Retry: CI failure is Prettier formatting error, not flaky test

PR Summary Enhancement: PR description has adequate technical depth; no value to add

⚙️ Options:

  • Auto-apply suggestions - Allow Gitar to commit updates to this branch

@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-redirect Ready Ready Preview Comment Nov 24, 2025 4:36pm
tigris-os-docs Ready Ready Preview Comment Nov 24, 2025 4:36pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 24, 2025

Greptile Overview

Greptile Summary

Removed the limited-access-key IAM policy example documentation because string IAM conditions are not yet available in Tigris.

  • Deleted docs/iam/policies/examples/limited-access-key.md which contained examples using StringLike conditions with s3:prefix
  • Removed reference from docs/iam/index.md example policy list
  • Critical: Five broken references remain in other files that must be addressed:
    • sidebars.js:121 - sidebar navigation still references the deleted file
    • docs/model-storage/vast-ai.mdx:136 - tutorial links to deleted file
    • docs/model-storage/skypilot.mdx:147 - tutorial links to deleted file
    • docs/model-storage/fly-io.mdx:136 - tutorial links to deleted file
    • docs/model-storage/beam-cloud.mdx:152 - tutorial links to deleted file

Confidence Score: 0/5

  • This PR will break the documentation with multiple broken links
  • The PR removes documentation correctly from docs/iam/index.md but leaves five broken references across sidebars.js and four model-storage tutorial files, which will result in broken links when users click them
  • All files with broken references require immediate attention: sidebars.js, docs/model-storage/vast-ai.mdx, docs/model-storage/skypilot.mdx, docs/model-storage/fly-io.mdx, and docs/model-storage/beam-cloud.mdx

Important Files Changed

File Analysis

Filename Score Overview
docs/iam/index.md 5/5 Removed reference to deleted limited-access-key example from list
docs/iam/policies/examples/limited-access-key.md 5/5 File deleted due to unavailable string IAM conditions feature

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (4)

  1. docs/model-storage/vast-ai.mdx, line 136-138 (link)

    logic: Broken link to deleted limited-access-key.md. Remove or update this reference.

  2. docs/model-storage/skypilot.mdx, line 147-149 (link)

    logic: Broken link to deleted limited-access-key.md. Remove or update this reference.

  3. docs/model-storage/fly-io.mdx, line 136-138 (link)

    logic: Broken link to deleted limited-access-key.md. Remove or update this reference.

  4. docs/model-storage/beam-cloud.mdx, line 152-154 (link)

    logic: Broken link to deleted limited-access-key.md. Remove or update this reference.

2 files reviewed, 5 comments

Edit Code Review Agent Settings | Greptile

@gitar-bot
Copy link

gitar-bot bot commented Nov 24, 2025

CI failed for 9abcc9f: The CI build failed because the documentation file was deleted but the corresponding entry in sidebars.js was not removed in the same commit.

Issue

Docusaurus build is failing with an invalid sidebar configuration error:

Error: Invalid sidebar file at "sidebars.js".
These sidebar document ids do not exist:
- iam/policies/examples/limited-access-key

Root Cause

The commit that CI ran on (263dfdf87c835ebbb1fbad7fda831fbefc006528) only removed:

  1. docs/iam/policies/examples/limited-access-key.md (the documentation file)
  2. Updated docs/iam/index.md (removed the link reference)

However, it did not update sidebars.js to remove the reference to iam/policies/examples/limited-access-key from the sidebar items array.

Details

When checking the current HEAD commit (9abcc9f), it appears the sidebars.js file has been correctly updated to remove the reference. This suggests that:

  • There was an initial commit (263dfdf) that forgot to update sidebars.js
  • A subsequent force push updated the commit (9abcc9f) to include the sidebars.js change

The current local version shows sidebars.js correctly excludes the deleted document from lines 120-124.

Suggested Fix

The solution is to ensure the sidebars.js file removes the line containing "iam/policies/examples/limited-access-key" from the Example Policies items array (around line 121 in the original version). The fix should remove this specific line:

"iam/policies/examples/limited-access-key",  // ← This line needs to be removed

From the items array in the "Example Policies" category section, leaving only:

  • "iam/policies/examples/ip-restrictions"
  • "iam/policies/examples/date-time-restrictions"
  • "iam/policies/examples/training-job"

Reply with Gitar please fix to apply these suggestions.
Auto-apply is off - enable it here to let Gitar commit future updates automatically.
Did we get this right? 👍 / 👎 to help improve future analysis.

@MantasMiksys MantasMiksys merged commit ab690c2 into main Nov 24, 2025
11 checks passed
@MantasMiksys MantasMiksys deleted the mm/rm-limited-access-key-iam-example branch November 24, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants