fix: Fix no logs after daemonizing

Author: efirs

main.go

@@ -100,8 +100,6 @@ func main() {
 			flags.Foreground = true
 		}
 
-		cfg.InitLoggers(flags)
-
 		if !flags.Foreground {
 			daemonizer = NewDaemonizer()
 			// Do not close stderr before mounting to print mount errors
@@ -114,6 +112,8 @@ func main() {
 			}
 		}
 
+		cfg.InitLoggers(flags)
+
 		mainLog.Info().Str("version", cfg.Version).Msg("Starting TigrisFS version")
 		mainLog.Info().Str("bucketName", bucketName).Str("mountPoint", flags.MountPoint).Msg("Mounting")
 		mainLog.Info().Uint32("uid", flags.Uid).Uint32("defaultGid", flags.Gid).Msg("Default uid=gid")
@@ -148,6 +148,7 @@ func main() {
 			mainLog.Info().Msg("File system has been successfully mounted.")
 			if !flags.Foreground {
 				daemonizer.NotifySuccess(true)
+				mainLog.Debug().Msg("Process is daemonized. Closing stdout and stderr.")
 				mainLog.E(os.Stderr.Close())
 				mainLog.E(os.Stdout.Close())
 			}

main_nowindows.go

@@ -32,7 +32,6 @@ import (
 	daemon "github.com/sevlyar/go-daemon"
 	"github.com/tigrisdata/tigrisfs/core"
 	"github.com/tigrisdata/tigrisfs/core/cfg"
-	"github.com/tigrisdata/tigrisfs/log"
 )
 
 var signalsToHandle = []os.Signal{os.Interrupt, syscall.SIGTERM, syscall.SIGUSR1}
@@ -92,17 +91,13 @@ func (p *Daemonizer) Daemonize(logFile string) error {
 	}
 
 	if child != nil {
-		log.Debug().Int("pid", os.Getpid()).Msg("parent")
 		// attempt to wait for child to notify parent
 		if p.Wait() {
-			log.Debug().Int("pid", os.Getpid()).Msg("parent exiting")
 			os.Exit(0)
 		} else {
-			log.Debug().Int("pid", os.Getpid()).Msg("inval")
 			return syscall.EINVAL
 		}
 	} else {
-		log.Debug().Int("pid", os.Getpid()).Msg("child")
 		p.Cancel()
 		mainLog.E(ctx.Release())
 	}

test/cases/tigris_posix_meta.sh

@@ -18,21 +18,41 @@ set -ex
 . "$(dirname "$0")/../mount.sh"
 
 CASE=posix_meta
-DIR=$MNT_DIR/$CASE/$RANDOM
+DIR="$MNT_DIR/$CASE/$RANDOM"
 
-df -h
+mkdir -p "$DIR"
+fn="$DIR/file.$RANDOM"
 
-mkdir -p $DIR
-fn=$DIR/file.$RANDOM
-touch $fn
-[ "$(stat -c '%G' $fn)" == "$USER" ]
-chown $USER:users $fn
-[ "$(stat -c '%G' $fn)" == "users" ]
-touch $fn
-[ "$(stat -c '%G' $fn)" == "users" ]
+# Test group id
+touch "$fn"
+[ "$(stat -c '%G' $fn)" == "$USER" ] || exit 1
+chown "$USER:users" "$fn"
+[ "$(stat -c '%G' "$fn")" == "users" ] || exit 1
+touch "$fn"
+[ "$(stat -c '%G' $fn)" == "users" ] || exit 1
+[ "$(stat -c '%A' $fn)" == "-rw-rw-r--" ] || exit 1
+chmod 600 "$fn"
+[ "$(stat -c '%A' $fn)" == "-rw-------" ] || exit 1
 
-_umount $MNT_DIR
-FS_BIN=$(dirname "$0")/../../tigrisfs _mount $MNT_DIR --enable-perms
+# Test symlink
+ln -s "$fn" "${fn}_link"
+[ -L "${fn}_link" ] || exit 1
+
+# Test fifo
+mkfifo "${fn}_fifo"
+ls -la $DIR
+[ "$(stat -c '%A' ${fn}_fifo)" == "prw-rw-r--" ] || exit 1
+chmod 600 "${fn}_fifo"
+[ "$(stat -c '%A' ${fn}_fifo)" == "prw-------" ] || exit 1
+[ -p "${fn}_fifo" ] || exit 1
+
+# Test attributes persisted after restart
+_umount "$MNT_DIR"
+FS_BIN=$(dirname "$0")/../../tigrisfs _mount "$MNT_DIR" --enable-specials --enable-perms
 sleep 5
 
-[ "$(stat -c '%G' $fn)" == "users" ]
+[ "$(stat -c '%G' $fn)" == "users" ] || exit 1
+[ "$(stat -c '%A' $fn)" == "-rw-------" ] || exit 1
+[ -L "${fn}_link" ] || exit 1
+[ -p "${fn}_fifo" ] || exit 1
+[ "$(stat -c '%A' ${fn}_fifo)" == "prw-------" ] || exit 1

test/run-cases.sh

@@ -2,21 +2,22 @@
 
 set -ex
 
-export MNT_DIR=$(mktemp -d)
+MNT_DIR=$(mktemp -d)
+export MNT_DIR
 
-export BUCKET_NAME="tigrisfs-test"
-export ENDPOINT="http://localhost:8080"
+export BUCKET_NAME="tigrisfs-test.$RANDOM"
+export ENDPOINT=${ENDPOINT:-"http://localhost:8080"}
 
 . "$(dirname "$0")/mount.sh"
 
 _s3cmd mb s3://$BUCKET_NAME
 
-_mount "$MNT_DIR" --enable-perms
-trap "_umount $MNT_DIR" EXIT
+_mount "$MNT_DIR" --enable-specials --enable-perms
+trap '_umount $MNT_DIR' EXIT
 
 sleep 5
 
 for c in $(find test/cases -type f -name "*.sh"); do
     echo "Running $c"
     /bin/bash "$c"
-done
+done