Skip to content

Conversation

@efirs
Copy link
Contributor

@efirs efirs commented May 29, 2025

No description provided.

Copilot AI review requested due to automatic review settings May 29, 2025 17:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the behavior of the Tigris prefetch functionality by disabling it by default. It updates the CLI flag name from a negative ("no-tigris-prefetch") to a positive ("tigris-prefetch") flag and adjusts the associated logic in both flag population and default flag settings.

@efirs efirs changed the title Disable prefetch on list by default fix: Disable prefetch on list by default May 29, 2025
@efirs efirs merged commit 5bf51d1 into main May 29, 2025
5 of 6 checks passed
@efirs efirs deleted the no_prefetch branch May 29, 2025 17:23
@tvogel
Copy link

tvogel commented Sep 4, 2025

I am interested in the background of this. Would it make sense for me to use --no-tigris-prefetch with the release 1.2.1 when I am primarily interested in ctime and size (for determining incremental backup scope)? Are there other optimizations, I should look at?

@ovaistariq
Copy link
Contributor

Prefetch is disabled by default now. You don't have to pass the --no-tigris-prefetch flag.

@tvogel
Copy link

tvogel commented Sep 5, 2025

I don't think, this applies to the latest tagged release, see https://github.com/tigrisdata/tigrisfs/blob/v1.2.1/core/cfg/flags.go#L1141 .

What was the reason to disable it by default (in this PR)?

@ovaistariq
Copy link
Contributor

You are right.

It was disabled by default because users with large datasets found the prefetching of files on listing unexpected. So we want to let the users choose this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants