fix: Fix no logs after daemonizing #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (2)
- test/cases/tigris_posix_meta.sh: Language not supported
- test/run-cases.sh: Language not supported
Comments suppressed due to low confidence (2)
main_nowindows.go:93
- Ensure that removing the debug log messages for both the parent and child processes does not reduce visibility in the daemonization process's failure scenarios. Verify the new logging behavior provides adequate context for troubleshooting.
if child != nil {
main.go:115
- Re-initializing the loggers after daemonization might override earlier configuration; please confirm that this ordering meets the intended logging setup without causing unintended side effects.
cfg.InitLoggers(flags)
efirs
force-pushed
the
fix_logger_daemonize
branch
from
fd22a99 to
58023a5
Compare
efirs
changed the title
efirs
force-pushed
the
fix_logger_daemonize
branch
2 times, most recently
from
5e280ea to
02647ef
Compare
himank
approved these changes
Apr 9, 2025
efirs
force-pushed
the
fix_logger_daemonize
branch
from
02647ef to
0cffdd2
Compare
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.