AsRef/Mut and From traits implementation on Key and Value (#26)

* Remove static lifetime restrictions on Key/Value From impl

Signed-off-by: Clément Renault <[email protected]>

* Add AsMut impl to Value and Key

Signed-off-by: Clément Renault <[email protected]>

* Allow constructing Key and Value from static str

Signed-off-by: Clément Renault <[email protected]>

Author: Kerollmops

src/lib.rs

@@ -220,16 +220,20 @@ impl From<String> for Key {
     }
 }
 
-impl<'a> From<&'static str> for Key {
+impl From<&'static str> for Key {
     fn from(v: &'static str) -> Key {
-        let mut vec = Vec::new();
-        vec.extend_from_slice(v.as_bytes());
-        Key(vec)
+        Key(v.as_bytes().to_vec())
     }
 }
 
 impl AsRef<Key> for Key {
-    fn as_ref(&self) -> &Self {
+    fn as_ref(&self) -> &Key {
+        self
+    }
+}
+
+impl AsMut<Key> for Key {
+    fn as_mut(&mut self) -> &mut Key {
         self
     }
 }
@@ -240,6 +244,12 @@ impl AsRef<[u8]> for Key {
     }
 }
 
+impl AsMut<[u8]> for Key {
+    fn as_mut(&mut self) -> &mut [u8] {
+        &mut self.0
+    }
+}
+
 impl Deref for Key {
     type Target = [u8];
 
@@ -326,9 +336,7 @@ impl From<String> for Value {
 
 impl From<&'static str> for Value {
     fn from(v: &'static str) -> Value {
-        let mut vec = Vec::new();
-        vec.extend_from_slice(v.as_bytes());
-        Value(vec)
+        Value(v.as_bytes().to_vec())
     }
 }
 
@@ -340,12 +348,19 @@ impl Deref for Value {
     }
 }
 
+impl AsRef<[u8]> for Value {
+    fn as_ref(&self) -> &[u8] {
+        &self.0
+    }
+}
+
 impl fmt::Debug for Value {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         match str::from_utf8(&self.0) {
             Ok(s) => write!(f, "Value({:?})", s),
             Err(_) => write!(f, "Value({})", HexRepr(&self.0)),
         }
+
     }
 }