tidy up debugging cruft

Author: timbray

lib/benchmarks_test.go

@@ -126,10 +126,10 @@ func TestCityLots(t *testing.T) {
 		message1 := fmt.Sprintf("Events-per-second benchmark ran at %.0f events per second, below threshold of %.0f.",
 			perSecond, thresholdPerformance)
 		message2 := `
-		It may be that re-running the benchmark test will address this, or it may be that you're running on a machine
-		that is slower than the one the software was developed on, in which case you might want to readjust the
-		"thresholdPerformance" constant. However, it may be that you made a change that reduced the throughput of the
-		library, which would be unacceptable.`
+			It may be that re-running the benchmark test will address this, or it may be that you're running on a machine
+			that is slower than the one the software was developed on, in which case you might want to readjust the
+			"thresholdPerformance" constant. However, it may be that you made a change that reduced the throughput of the
+			library, which would be unacceptable.`
 		t.Errorf(message1 + message2)
 	}
 

lib/small_table.go

@@ -70,17 +70,11 @@ func newSmallTable[S comparable]() *smallTable[S] {
 	}
 }
 
+// step finds the step in the smallTable that corresponds to the utf8Byte argument. It may return nil.
 func (t *smallTable[S]) step(utf8Byte byte) S {
-	// In a genericized context you can't just throw around "nil" you declare a variable and
-	//  Go will ensure it has the zero value, i.e. nil
-	var nilS S
 	for index, ceiling := range t.slices.ceilings {
 		if utf8Byte < ceiling {
-			if t.slices.steps[index] == nilS {
-				return nilS
-			} else {
-				return t.slices.steps[index]
-			}
+			return t.slices.steps[index]
 		}
 	}
 	panic("Malformed smallTable")