Reduce number of declared files in emit_stdlib (bazel-contrib#3366)

* The `src` directory is declared, but not passed to downstream rules.
  It has been declared since cfc58d9,
  but hasn't been exposed since 3680494
* Instead of writing a new root file, use the existing `pkg` directory.

Author: fmeum

go/private/actions/stdlib.bzl

@@ -75,14 +75,11 @@ def _sdk_stdlib(go):
 
 def _build_stdlib(go):
     pkg = go.declare_directory(go, path = "pkg")
-    src = go.declare_directory(go, path = "src")
-    root_file = go.declare_file(go, path = "ROOT")
     args = go.builder_args(go, "stdlib")
-    args.add("-out", root_file.dirname)
+    args.add("-out", pkg.dirname)
     if go.mode.race:
         args.add("-race")
     args.add_all(link_mode_args(go.mode))
-    go.actions.write(root_file, "")
     env = go.env
     if go.mode.pure:
         env.update({"CGO_ENABLED": "0"})
@@ -105,7 +102,7 @@ def _build_stdlib(go):
               go.sdk.tools +
               [go.sdk.go, go.sdk.package_list, go.sdk.root_file] +
               go.crosstool)
-    outputs = [pkg, src]
+    outputs = [pkg]
     go.actions.run(
         inputs = inputs,
         outputs = outputs,
@@ -117,5 +114,5 @@ def _build_stdlib(go):
     return GoStdLib(
         _list_json = _build_stdlib_list_json(go),
         libs = [pkg],
-        root_file = root_file,
+        root_file = pkg,
     )

go/providers.rst

@@ -428,7 +428,7 @@ from GoSDK_, or it may be another library compiled for the target mode.
 +--------------------------------+-----------------------------------------------------------------+
 | :param:`root_file`             | :type:`File`                                                    |
 +--------------------------------+-----------------------------------------------------------------+
-| A file in the standard library root directory. Used to determine ``GOROOT``.                     |
+| A file or directory in the standard library root directory. Used to determine ``GOROOT``.                     |
 +--------------------------------+-----------------------------------------------------------------+
 | :param:`libs`                  | :type:`list of File`                                            |
 +--------------------------------+-----------------------------------------------------------------+