Skip to content

Commit 191f8d2

Browse files
committed
leaving txen on for a bit more lowers packet loss from 10 to 5%
1 parent 9882557 commit 191f8d2

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

rp2-pio/piolib/rmii-tx.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func (r *RMIITx) Configure(PIO *pio.PIO, cfg RMIITxConfig) error {
5757
mskTXEN = (1 << idxTxEN) * (1 - sideTXEN)
5858

5959
labelPreambleData = 2
60-
labelTxDeassert = labelPreambleData + 3
60+
labelTxDeassert = labelPreambleData + 4
6161
labelTxIdle = labelTxDeassert + 2
6262
polRising = true
6363
)
@@ -75,8 +75,9 @@ func (r *RMIITx) Configure(PIO *pio.PIO, cfg RMIITxConfig) error {
7575
asm.Out(pio.OutDestPins, 2).Side(sideTXEN).Encode(),
7676
asm.Jmp(pio.JmpXNZeroDec, labelPreambleData).Side(sideTXEN).Encode(),
7777

78+
// Why does a little more TXEN time yield better results?
79+
asm.Set(pio.SetDestPins, 0).Side(sideTXEN).Encode(),
7880
// Send inter-packet-gap(IPG) with TXEN deasserted.
79-
asm.Set(pio.SetDestPins, 0).Side(0).Encode(),
8081
labelTxDeassert:// Deassertion of first 32 dibits=4 bytes.
8182
asm.Nop().Side(0).Encode(),
8283
asm.Jmp(pio.JmpYNZeroDec, labelTxDeassert).Side(0).Encode(),

0 commit comments

Comments
 (0)