compiler: emit a nil check when slicing an array pointer

niaow · aykevl · commit f159429152e9 · 2021-01-15T21:35:49.000+01:00
diff --git a/compiler/compiler.go b/compiler/compiler.go
@@ -1852,6 +1852,7 @@ func (b *builder) createExpr(expr ssa.Value) (llvm.Value, error) {
 				low,
 			}
 
+			b.createNilCheck(expr.X, value, "slice")
 			b.createSliceBoundsCheck(llvmLen, low, high, max, lowType, highType, maxType)
 
 			// Truncate ints bigger than uintptr. This is after the bounds

Original file line number	Diff line number	Diff line change
`@@ -1852,6 +1852,7 @@ func (b *builder) createExpr(expr ssa.Value) (llvm.Value, error) {`
`1852`	`1852`	`low,`
`1853`	`1853`	`}`
`1854`	`1854`
	`1855`	`+ b.createNilCheck(expr.X, value, "slice")`
`1855`	`1856`	`b.createSliceBoundsCheck(llvmLen, low, high, max, lowType, highType, maxType)`
`1856`	`1857`
`1857`	`1858`	`// Truncate ints bigger than uintptr. This is after the bounds`