Skip to content

Commit f4f2b8e

Browse files
committed
ci: build LLVM with thread support on Windows
This should fix a number of concurrency/threading issues.
1 parent 623dd6a commit f4f2b8e

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

.github/workflows/windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
uses: actions/cache@v2
5656
id: cache-llvm-build
5757
with:
58-
key: llvm-build-14-windows-v2
58+
key: llvm-build-14-windows-v3
5959
path: llvm-build
6060
- name: Build LLVM
6161
if: steps.cache-llvm-build.outputs.cache-hit != 'true'

Makefile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,11 +114,6 @@ ifeq ($(OS),Windows_NT)
114114
START_GROUP = -Wl,--start-group
115115
END_GROUP = -Wl,--end-group
116116

117-
# LLVM compiled using MinGW on Windows appears to have problems with threads.
118-
# Without this flag, linking results in errors like these:
119-
# libLLVMSupport.a(Threading.cpp.obj):Threading.cpp:(.text+0x55): undefined reference to `std::thread::hardware_concurrency()'
120-
LLVM_OPTION += -DLLVM_ENABLE_THREADS=OFF -DLLVM_ENABLE_PIC=OFF
121-
122117
CGO_CPPFLAGS += -DCINDEX_NO_EXPORTS
123118
CGO_LDFLAGS += -static -static-libgcc -static-libstdc++
124119
CGO_LDFLAGS_EXTRA += -lversion

0 commit comments

Comments
 (0)