Skip to content

todo: go on interface call #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fgsch opened this issue Jun 18, 2021 · 7 comments
Closed

todo: go on interface call #1961

fgsch opened this issue Jun 18, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@fgsch
Copy link
Contributor

fgsch commented Jun 18, 2021

This was discussed on slack a while back, but for the record, the code below fails with /usr/local/Cellar/go/1.16.5/libexec/src/net/http/transport.go:1587:5: todo: go on interface call:

package main

import (
	"fmt"
	"net/http"
)

func main() {
	fmt.Println(http.Cookie{})
}

TinyGo version:

tinygo version 0.19.0-dev-1913cb76 darwin/amd64 (using go version go1.16.5 and LLVM version 11.0.0)

Invocation:

tinygo build -target wasm -o main.wasm main.go

@deadprogram deadprogram added the bug Something isn't working label Jun 18, 2021
@fgsch fgsch changed the title todo: go on interface call [DEV] todo: go on interface call Jun 21, 2021
@aykevl
Copy link
Member

aykevl commented Jun 21, 2021

I looked into this before and I believe my conclusion was that it's easier to finish refactoring the reflect package first.

@fgsch fgsch changed the title [DEV] todo: go on interface call todo: go on interface call Jul 2, 2021
@esimov
Copy link

esimov commented Oct 23, 2021

This error is still happening for me. Is there any resolution regarding this issue?

@aykevl
Copy link
Member

aykevl commented Oct 24, 2021

I have implemented this, after refactoring how interfaces are type asserted and interface methods are called: #2202

@esimov
Copy link

esimov commented Oct 25, 2021

Thank you. I've tried to install it again via Homebrew, but I'm afraid is not updated yet, because I'm still receiving the above error.

@aykevl
Copy link
Member

aykevl commented Oct 25, 2021

It's only a PR yet, not yet merged into the development branch even. So no, it's not part of Homebrew yet.

@esimov
Copy link

esimov commented Oct 25, 2021

All right, thanks.

@dgryski
Copy link
Member

dgryski commented Nov 18, 2021

Support for "go on interfaces" as been merged and tinygo 0.21 was released with this fix. Closing this bug. Please re-open if you're still encountering problems.

@dgryski dgryski closed this as completed Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants