Skip to content

runtime/compiler/transform (gc): generated code includes many 0-sized heap allocation calls #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
niaow opened this issue Oct 13, 2021 · 1 comment
Closed

runtime/compiler/transform (gc): generated code includes many 0-sized heap allocation calls #2173

niaow opened this issue Oct 13, 2021 · 1 comment
Labels
core

Comments

@niaow
Copy link
Member

niaow commented Oct 13, 2021

When debugging some code for #2011, I noticed tons of runtime.alloc(i32 0) calls scattered throughout the IR.
It could be beneficial to rewrite them to a pointer to a single global.
This would eliminate a call, and allow LLVM to preform more optimizations.
@niaow niaow added the core label Oct 13, 2021
@niaow niaow changed the title runtime/compiler/transform (gc): generated code many 0-sized heap allocation calls runtime/compiler/transform (gc): generated code includes many 0-sized heap allocation calls Oct 13, 2021
@niaow
Copy link
Member Author

niaow commented Nov 14, 2021

Nevermind, this only seems to affect leaking.

@niaow niaow closed this as completed Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@niaow