Skip to content

Split in multiple packages #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tkrotoff opened this issue Nov 1, 2017 · 2 comments
Closed

Split in multiple packages #12

tkrotoff opened this issue Nov 1, 2017 · 2 comments

Comments

@tkrotoff
Copy link
Owner

tkrotoff commented Nov 1, 2017

Instead of
import { ... } from 'react-form-with-constraints/lib/Native'
import { ... } from 'react-form-with-constraints/lib/Bootstrap4'

Introduce multiple npm packages:

  • react-form-with-constraints
  • react-form-with-constraints-dom
  • react-form-with-constraints-native
  • react-form-with-constraints-bootstrap4

Will also solve some TypeScript typings:

node_modules/@types/node/index.d.ts(117,13): error TS2300: Duplicate identifier 'require'.
node_modules/@types/react-native/index.d.ts(8584,14): error TS2300: Duplicate identifier 'require'.

See DefinitelyTyped/DefinitelyTyped#16825

error TS2415: Class 'FormWithConstraints' incorrectly extends base class 'FormWithConstraints'.
  Types of property 'validateFields' are incompatible.
@tkrotoff
Copy link
Owner Author

Problem with react-native, see yarnpkg/yarn#3882

@tkrotoff
Copy link
Owner Author

See c28d123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant