Skip to content

Commit 11fac7e

Browse files
t1m4lct1m4lc
committed
refactor: review fix 2
1 parent 013fb00 commit 11fac7e

27 files changed

+29
-24
lines changed

‎apps/angular/dialog-alert-form/.eslintrc.json renamed to ‎apps/forms/form-dialog-alert/.eslintrc.json

File renamed without changes.

‎apps/angular/dialog-alert-form/README.md renamed to ‎apps/forms/form-dialog-alert/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
# Save your form's bacon: with the navigation alert
1+
# Save the form data with the navigation alert
22

33
> author: [Timothy Alcaide](https://github.com/alcaidio)
44
55
### Run Application
66

77
```bash
8-
npx nx serve angular-dialog-alert-form
8+
npx nx serve form-dialog-alert
99
```
1010

11-
Challenge documentation is [here](https://angular-challenges.vercel.app/challenges/angular/48-dialog-alert-form/).
11+
Challenge documentation is [here](https://angular-challenges.vercel.app/challenges/forms/48-form-dialog-alert/).

‎apps/angular/dialog-alert-form/project.json renamed to ‎apps/forms/form-dialog-alert/project.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
11
{
2-
"name": "angular-dialog-alert-form",
2+
"name": "form-dialog-alert",
33
"$schema": "../../../node_modules/nx/schemas/project-schema.json",
44
"projectType": "application",
55
"prefix": "app",
6-
"sourceRoot": "apps/angular/dialog-alert-form/src",
6+
"sourceRoot": "apps/forms/form-dialog-alert/src",
77
"tags": [],
88
"targets": {
99
"build": {
1010
"executor": "@angular-devkit/build-angular:application",
1111
"outputs": ["{options.outputPath}"],
1212
"options": {
13-
"outputPath": "dist/apps/angular/dialog-alert-form",
14-
"index": "apps/angular/dialog-alert-form/src/index.html",
15-
"browser": "apps/angular/dialog-alert-form/src/main.ts",
13+
"outputPath": "dist/apps/forms/form-dialog-alert",
14+
"index": "apps/forms/form-dialog-alert/src/index.html",
15+
"browser": "apps/forms/form-dialog-alert/src/main.ts",
1616
"polyfills": ["zone.js"],
17-
"tsConfig": "apps/angular/dialog-alert-form/tsconfig.app.json",
17+
"tsConfig": "apps/forms/form-dialog-alert/tsconfig.app.json",
1818
"inlineStyleLanguage": "scss",
1919
"assets": [
20-
"apps/angular/dialog-alert-form/src/favicon.ico",
21-
"apps/angular/dialog-alert-form/src/assets"
20+
"apps/forms/form-dialog-alert/src/favicon.ico",
21+
"apps/forms/form-dialog-alert/src/assets"
2222
],
23-
"styles": ["apps/angular/dialog-alert-form/src/styles.scss"],
23+
"styles": ["apps/forms/form-dialog-alert/src/styles.scss"],
2424
"scripts": []
2525
},
2626
"configurations": {
@@ -51,18 +51,18 @@
5151
"executor": "@angular-devkit/build-angular:dev-server",
5252
"configurations": {
5353
"production": {
54-
"buildTarget": "angular-dialog-alert-form:build:production"
54+
"buildTarget": "form-dialog-alert:build:production"
5555
},
5656
"development": {
57-
"buildTarget": "angular-dialog-alert-form:build:development"
57+
"buildTarget": "form-dialog-alert:build:development"
5858
}
5959
},
6060
"defaultConfiguration": "development"
6161
},
6262
"extract-i18n": {
6363
"executor": "@angular-devkit/build-angular:extract-i18n",
6464
"options": {
65-
"buildTarget": "angular-dialog-alert-form:build"
65+
"buildTarget": "form-dialog-alert:build"
6666
}
6767
},
6868
"lint": {

‎apps/angular/dialog-alert-form/src/app/app.component.ts renamed to ‎apps/forms/form-dialog-alert/src/app/app.component.ts

File renamed without changes.

‎apps/angular/dialog-alert-form/src/app/app.config.ts renamed to ‎apps/forms/form-dialog-alert/src/app/app.config.ts

File renamed without changes.

‎apps/angular/dialog-alert-form/src/app/app.routes.ts renamed to ‎apps/forms/form-dialog-alert/src/app/app.routes.ts

File renamed without changes.

‎apps/angular/dialog-alert-form/src/app/pages/join.component.ts renamed to ‎apps/forms/form-dialog-alert/src/app/pages/join.component.ts

File renamed without changes.

‎apps/angular/dialog-alert-form/src/app/pages/page.component.ts renamed to ‎apps/forms/form-dialog-alert/src/app/pages/page.component.ts

File renamed without changes.

‎apps/angular/dialog-alert-form/src/app/ui/dialog.component.ts renamed to ‎apps/forms/form-dialog-alert/src/app/ui/dialog.component.ts

File renamed without changes.

‎apps/angular/dialog-alert-form/src/app/ui/form.component.ts renamed to ‎apps/forms/form-dialog-alert/src/app/ui/form.component.ts

File renamed without changes.

‎apps/angular/dialog-alert-form/src/app/ui/nav.component.ts renamed to ‎apps/forms/form-dialog-alert/src/app/ui/nav.component.ts

File renamed without changes.

‎apps/angular/dialog-alert-form/src/assets/.gitkeep renamed to ‎apps/forms/form-dialog-alert/src/assets/.gitkeep

File renamed without changes.

‎apps/angular/dialog-alert-form/src/favicon.ico renamed to ‎apps/forms/form-dialog-alert/src/favicon.ico

File renamed without changes.

‎apps/angular/dialog-alert-form/src/index.html renamed to ‎apps/forms/form-dialog-alert/src/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html lang="en">
33
<head>
44
<meta charset="utf-8" />
5-
<title>angular-dialog-alert-form</title>
5+
<title>form-dialog-alert</title>
66
<base href="/" />
77
<meta name="viewport" content="width=device-width, initial-scale=1" />
88
<link rel="icon" type="image/x-icon" href="favicon.ico" />

‎apps/angular/dialog-alert-form/src/main.ts renamed to ‎apps/forms/form-dialog-alert/src/main.ts

File renamed without changes.

‎apps/angular/dialog-alert-form/src/styles.scss renamed to ‎apps/forms/form-dialog-alert/src/styles.scss

File renamed without changes.

‎apps/angular/dialog-alert-form/tailwind.config.js renamed to ‎apps/forms/form-dialog-alert/tailwind.config.js

File renamed without changes.

‎apps/angular/dialog-alert-form/tsconfig.app.json renamed to ‎apps/forms/form-dialog-alert/tsconfig.app.json

File renamed without changes.

‎apps/angular/dialog-alert-form/tsconfig.editor.json renamed to ‎apps/forms/form-dialog-alert/tsconfig.editor.json

File renamed without changes.

‎apps/angular/dialog-alert-form/tsconfig.json renamed to ‎apps/forms/form-dialog-alert/tsconfig.json

File renamed without changes.

‎docs/src/components/Author.astro

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,11 @@ interface Props {
66
twitter?: string;
77
linkedin?: string;
88
github?: string;
9+
youtube?: string;
910
labels?: Record<string, string>;
1011
}
1112
12-
const { name, twitter, linkedin, github, data } = Astro.props;
13+
const { name, twitter, linkedin, github, youtube, data } = Astro.props;
1314
---
1415

1516
<p class="author">
@@ -23,6 +24,9 @@ const { name, twitter, linkedin, github, data } = Astro.props;
2324
{github && <a href={github}>
2425
<Icon class="icon" name="github" size="0.75rem" />
2526
</a>}
27+
{youtube && <a href={youtube}>
28+
<Icon class="icon" name="youtube" size="0.75rem" />
29+
</a>}
2630

2731
</p>
2832

‎docs/src/content/config.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ const authors = defineCollection({
88
twitter: z.string().url().optional(),
99
linkedin: z.string().url().optional(),
1010
github: z.string().url().optional(),
11+
youtube: z.string().url().optional(),
1112
}),
1213
});
1314

‎docs/src/content/docs/challenges/angular/48-dialog-alert-form.md renamed to ‎docs/src/content/docs/challenges/forms/48-dialog-alert-form.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
---
2-
title: 🟠 Save your form&#39;s bacon: with the navigation alert
2+
title: 🟠 Save the form data with the navigation alert
33
description: Challenge 48 is about Bob 🧙‍♂️ the product owner, he wants to develop a new feature in response to customer complaints about losing form input information.
44
author: timothy-alcaide
55
contributors:
6-
- Timothy Alcaide
6+
- alcaidio
77
challengeNumber: 48
8-
command: angular-dialog-alert-form
8+
command: form-dialog-alert
99
sidebar:
1010
order: 121
1111
badge: New

‎docs/src/content/docs/es/index.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ hero:
1313
icon: right-arrow
1414
variant: primary
1515
- text: Ir al Desafío más reciente
16-
link: /es/challenges/angular/48-dialog-alert-form/
16+
link: /es/challenges/forms/48-form-dialog-alert/
1717
icon: rocket
1818
- text: Dar una estrella
1919
link: https://github.com/tomalaforge/angular-challenges

‎docs/src/content/docs/fr/index.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ hero:
1313
icon: right-arrow
1414
variant: primary
1515
- text: Aller au dernier Challenge
16-
link: /fr/challenges/angular/48-dialog-alert-form/
16+
link: /fr/challenges/forms/48-form-dialog-alert/
1717
icon: rocket
1818
- text: Donne une étoile
1919
link: https://github.com/tomalaforge/angular-challenges

‎docs/src/content/docs/pt/index.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ hero:
1313
icon: right-arrow
1414
variant: primary
1515
- text: Ir para o desafio mais recente
16-
link: /pt/challenges/angular/48-dialog-alert-form/
16+
link: /pt/challenges/forms/48-form-dialog-alert/
1717
icon: rocket
1818
- text: Dar uma estrela
1919
link: https://github.com/tomalaforge/angular-challenges

‎docs/src/content/docs/ru/index.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ hero:
1313
icon: right-arrow
1414
variant: primary
1515
- text: Перейти к последней задаче
16-
link: /ru/challenges/angular/48-dialog-alert-form/
16+
link: /ru/challenges/forms/48-form-dialog-alert/
1717
icon: rocket
1818
- text: Добавить звезду
1919
link: https://github.com/tomalaforge/angular-challenges

0 commit comments

Comments
 (0)