HotFix for 0 Legacy ID

Author: James Cori

src/controllers/syncController.js

@@ -34,7 +34,7 @@ async function syncQueuedChallenges () {
         try {
           for (let i = 0; i < queuedChallenges.items.length; i += 1) {
             const item = queuedChallenges.items[i]
-            if (toString(item.legacyId) !== 'NaN') {
+            if (toString(item.legacyId) !== 'NaN' && item.legacyId > 0) {
               await syncService.syncLegacyId(toNumber(item.legacyId), item.force)
             } else {
               logger.error(`Sync Failed for Bad Legacy ID: ${item.legacyId}`)

src/scripts/migrations/010-fix-effort-hours.js

@@ -10,7 +10,8 @@ const config = require('config')
 const _ = require('lodash')
 const logger = require('../../util/logger')
 const challengeService = require('../../services/challengeService')
-const { getESClient } = require('../../util/helper')
+// const { getESClient } = require('../../util/helper')
+const moment = require('moment')
 const { execQuery, getEffortHoursFromIfx } = require('../../services/challengeInformixService')
 
 const mapping = {
@@ -41,6 +42,9 @@ const migrationFunction = {
           const legacyData = await getEffortHoursFromIfx(legacyIdRow.legacy_id)
           // logger.debug(`Legacy Data: ${JSON.stringify(legacyData)}`)
           if (legacyData.length > 0) {
+            if (!challenge.metadata) {
+              challenge.metadata = []
+            }
             _.forEach(mapping, (mappingValue, key) => {
               // logger.debug(`${JSON.stringify(mappingValue)} -> ${key}`)
               const v5Index = _.findIndex(challenge.metadata, meta => meta.name === key)
@@ -63,6 +67,8 @@ const migrationFunction = {
               }
             })
             // logger.debug(`Writing Challenge ${JSON.stringify(challenge)}`)
+            challenge.updated = moment().utc().format()
+            challenge.updatedBy = 'v5migration'
             await challengeService.save(challenge)
           }
         }
@@ -91,6 +97,7 @@ async function getEffortHoursChallengeIds (page, perPage) {
     DISTINCT project_id as legacy_id
     FROM project_info
     WHERE project_info_type_id in (88, 89, 90)
+    ORDER BY project_id ASC
   `
   logger.info(`Effort Hours SQL: ${sql}`)
   return execQuery(sql)

src/services/syncService.js

@@ -12,7 +12,13 @@ const { challengeStatusOrders } = require('../constants')
 
 async function syncLegacyId (legacyId, force) {
   // const legacyId = queuedChallenges.items[i].legacyId
-  const [v5] = await challengeService.getChallengeFromV5API(legacyId)
+  let v5
+  try {
+    [v5] = await challengeService.getChallengeFromV5API(legacyId)
+  } catch (e) {
+    logger.error(`syncLegacyId Failed ${e}`)
+    return false
+  }
   // see if v5 exists
   if (v5) {
     const v4Listing = await challengeService.getChallengeListingFromV4ES(legacyId)