Private member profiles should be open up in a new browser tab

[Oanh-and-only-Oanh]

1) Behavior: When a Topgear member clicks a member's handle, it navigates user to the public domain i.e. https://www.topcoder.com/members/Rinal

Expected behavior: When a Topgear member clicks a member's handle, user is navigated to the member's profile page WITHIN Topgear's domain. i.e. https://topgear.topcoder.com/members/Rinal

2) If the member's handle is NOT part of Topgear's groupID, when a Topgear user clicks on a public member handle, this image and message should appear.

As we have discussed, we will implement this logic:

1. When we are under topgear domain, e.g. topgear.topcoder-dev.com, we then should open up a member's profile page in a new tab, (with the subdomain info retained in the url of the new browser tab)

2. When we are under public domain, e.g. www.topcoder-dev.com, we should retain the logic as is.

The updated requirement work will be done against feature-private-navigation

[LieutenantRoger]

@Oanh-and-only-Oanh For #1, we seems not having a challenge that can allow us to reproduce this in the topgear domain right now. https://topgear.topcoder-dev.com/challenges , all the challenges in this page can't display detail. So where we can find a member to click under topgear domain in development envrionment? Maybe @urwithat can help to create a one so we can reproduce this

[LieutenantRoger]

#2, why a topgear user is able to click a member's handle in public domain ? I seems could only think up that this scenario will happen only when a topgear user try to fill the link in the browser directly like this: https://topgear.topcoder.com/members/Rinal

[LieutenantRoger]

FYI, I have draft a challenge spec for this ticket, please take a look:
https://docs.google.com/document/d/1FzTgw7HcOicgOzlWyMd1AmPHId5F9FljRWyVn2MI9_A/edit?usp=sharing

[Oanh-and-only-Oanh]

@atif, please help with question 1 above.

[Oanh-and-only-Oanh]

question 2. @LieutenantRoger, a scenario would be...

[LieutenantRoger]

Question 1: I found two challenges that allowing us to see a member handle.

https://topgear.topcoder-dev.com/challenges/30055960?tab=registrants
https://topgear.topcoder-dev.com/challenges/30055753?tab=registrants

For this, it looks we need to find all areas on the topgear site where it shows a member's handle, this looks like a side task.

@Oanh-and-only-Oanh

1. I think we need a separate task to find all the url links where the displayed content has member handle rendered.
2. Do we need to take care of other private group or only topgear

Question 2: The comment seems not complete.

[LieutenantRoger]

https://docs.google.com/document/d/1QEvbKQ9xPKqMZqWv_Fu9SQOMBQaWAAM39bpMj_yTDuc/edit?usp=sharing

Here's a challenge spec to find all the URLs which contain member handle link under the topgear domain.

[Oanh-and-only-Oanh]

Question 2: takes this challenge for example, https://topgear.topcoder.com/challenges/30118814, it's a public challenge but it's also made available on topgear. So if a topgear user goes into the registrant or submission tabs of that challenge and clicks on a public member's handle, it will take the user to the public domain. We want to change it so if it is a public handle, the topgear member should see below instead.

[LieutenantRoger]

I don't have access to above challenge. I think we need to setup a test challenge under topgear.topcoder-dev.com while we can use TonyJ user to visit, and this challenge will contain both topgear user and public user in registration and submission tab.

We will perhaps setup up more public handles in topgear domain in other areas (identified here: https://docs.google.com/document/d/1QEvbKQ9xPKqMZqWv_Fu9SQOMBQaWAAM39bpMj_yTDuc/edit?usp=sharing) to verify the navigation as well.

[Oanh-and-only-Oanh]

@lakshmiathreya, can you help with the above? We need to set up a test challenge under topgear.topcoder-dev.com

[LieutenantRoger]

We need similar challenges in below private group as well in order to test the result:

https://cs.topcoder-dev.com/challenges
https://veterans.topcoder-dev.com/challenges
https://blockchain.topcoder-dev.com/challenges?communityId=blockchain
https://cognitive.topcoder-dev.com/challenges?communityId=cognitive

[LieutenantRoger]

@Oanh-and-only-Oanh

Is it possible a public member only can register a private group challenge ?

It seems impossible given the current business logic as the private group challenge won't be visiable to public member.

[LieutenantRoger]

@Oanh-and-only-Oanh

Please try to click the member-handles under this screen:

https://topgear.topcoder-dev.com/challenges/30055646?tab=registrants

https://topgear.topcoder-dev.com/members/tester1234 (Here is an example when a user is not having stats data).

https://topgear.topcoder-dev.com/members/dan_developer (Here is another example when a user is having stats data).

[Oanh-and-only-Oanh]

@LieutenantRoger, a public member cannot register for a private group challenge because it will not be visible on the public domain.

[LieutenantRoger]

Right , so topgear user under topgear domain won't able to click a public member to visit its profile, this will lead to point 2 above will never happen.

So for a topgear user who does't have history data, could you check wheather this meet expectation above ?
https://topgear.topcoder-dev.com/members/tester1234

[Oanh-and-only-Oanh]

Right , so topgear user under topgear domain won't able to click a public member to visit its profile, this will lead to point 2 above will never happen.

topgear user can click on public member but it will show below

So for a topgear user who does't have history data, could you check wheather this meet expectation above ? https://topgear.topcoder-dev.com/members/tester1234

Correct

[LieutenantRoger]

>> topgear user can click on public member but it will show below

Could you please tell how a topgear user click on public member's handle ? In another word, will public members show up on topgear.topcoder.com site ?

[Oanh-and-only-Oanh]

all public challenges are visible on the topgear site so if a public member registers for a public challenge, a topgear user would be able to see the public user's handle in the topgear site.

[LieutenantRoger]

Ah, got it, that clarifies this.

[LieutenantRoger]

Hi @Oanh-and-only-Oanh

Does this look fine when a topgear user visit public member's profile screen ?

https://take.ms/34K4P

[Oanh-and-only-Oanh]

That's correct.

[sandhiyakavi]

Tested the Fix.The Topgear user is still able to see the public member's handle details.

I have also attached video for better clarity.

issue#4082_video.zip

[sandhiyakavi]

@LieutenantRoger If we click the member handle from the member search results, it is directing to the member profile from the legacy page.

Attached video for the same.

member_search_legacypage.zip

[sandhiyakavi]

Other than the above issue, everything is good

Topgear page:

1. Challenge Details: Registrants, Submission and Winners- Opens in new tab - Pass
2. Profile->Stats history: all the link opens in new tab - Pass
3. Leaderboard: Opens in new tab but displays 404 HTTP error (need to test in Prod)

Topcoder page:

1. Challenge Details: Registrants, Submission and Winners- Opens in same tab - Pass
2. Profile->Stats history: all the link opens in same tab - Pass
3. Member search->opens in same tab but legacy page displayed.(above mentioned issue).

[LieutenantRoger]

@SathyaJayabal It's environment issue, because the search page on dev environment is routing to legacy app, but the search in production page is still inside community-app.

We are not using legacy search page in production, so we don't need to fix the legacy page. I guess @sushilshinde will have to update the search route on the dev environment to be served inside community-app as well.

Here's a snapshot for comparison.

https://take.ms/G4qlQ

[SathyaJayabal]

@LieutenantRoger marking this as pass as per previous comment

[sushilshinde]

@LieutenantRoger please raise PR to develop

[SathyaJayabal]

Verified on dev env(develop branch)
Topgear pages:
Challenge Details: Registrants, Submission and Winners- Opens in new tab - Pass
Profile->Stats history: all the link opens in new tab - Pass
Leaderboard: Opens in new tab-verified this one on beta.
topgear leaderboard.mov.zip

Topcoder pages:
Challenge Details: Registrants, Submission and Winners- Opens in same tab - Pass
Profile->Stats history: all the link opens in same tab - Pass
Member search->opens in same tab. verified this one on beta.
search results.mov.zip

[sandhiyakavi]

@LieutenantRoger @Oanh-and-only-Oanh Need clarification for the below.

In the tco20 pages,
Leaderboard page: https://tco20.topcoder.com/competition-overview/qa/leaderboard
Regional Leaderboard page: https://tco20.topcoder.com/regional-events/southern-asia/leaderboard
Opens in new tab with the url like https://tco20.topcoder.com/members/cyberjag/ . is that the expected behaviour?

Leaderboard_page.zip
RegionalEvent_leaderboard_page.zip

[LieutenantRoger]

Hi @sandhiyakavi

I think this is expected behavior. tco20.topcoder.com can be treated as a sub-community as well, as it is for tco20 only.

@Oanh-and-only-Oanh please comment more if you have otherwise opinion. :)

[sandhiyakavi]

Except the above clarification.Everything else is working fine.

Topgear pages:
Challenge Details: Registrants, Submission and Winners- Opens in new tab - Pass
Leaderboard: Opens in new tab - Pass

Topcoder pages:
Challenge Details: Registrants, Submission and Winners- Opens in same tab - Pass
Profile->Stats history: all the link opens in same tab - Pass
Member search->opens in same tab - Pass

[lakshmiathreya]

@SathyaJayabal - why isnt this set to Pass?