Do not update record unnecessarily

callmekatootie · callmekatootie · commit e372de746932 · 2021-02-25T19:10:30.000+05:30
diff --git a/scripts/updateToV5ChallengeId.js b/scripts/updateToV5ChallengeId.js
@@ -38,12 +38,11 @@ function * updateRecord (submission, failedContainer) {
   if (!v5challengeId) {
     logger.warn(`the challengeId: ${submission.challengeId} is not having a v5 challengeId`)
     failedContainer.push(submission)
-    return
   } else if (v5challengeId === submission.challengeId) {
     logger.info(`the challengeId: ${submission.challengeId} is already a v5 challengeId`)
+  } else {
+    yield dbhelper.updateRecord(record)
   }
-
-  yield dbhelper.updateRecord(record)
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -38,12 +38,11 @@ function * updateRecord (submission, failedContainer) {`
`38`	`38`	`if (!v5challengeId) {`
`39`	`39`	logger.warn(`the challengeId: ${submission.challengeId} is not having a v5 challengeId`)
`40`	`40`	`failedContainer.push(submission)`
`41`		`- return`
`42`	`41`	`} else if (v5challengeId === submission.challengeId) {`
`43`	`42`	logger.info(`the challengeId: ${submission.challengeId} is already a v5 challengeId`)
	`43`	`+ } else {`
	`44`	`+ yield dbhelper.updateRecord(record)`
`44`	`45`	`}`
`45`		`-`
`46`		`- yield dbhelper.updateRecord(record)`
`47`	`46`	`}`
`48`	`47`
`49`	`48`	`/*`